Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sandboxing into the constellation crate. #11325

Merged
merged 1 commit into from May 22, 2016
Merged

Move sandboxing into the constellation crate. #11325

merged 1 commit into from May 22, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 22, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs, components/constellation/sandboxing.rs, components/constellation/lib.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 22, 2016
@nox
Copy link
Contributor

nox commented May 22, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f4c4977 has been approved by nox

@highfive highfive assigned nox and unassigned wafflespeanut May 22, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 22, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit f4c4977 with merge af1b489...

bors-servo pushed a commit that referenced this pull request May 22, 2016
Move sandboxing into the constellation crate.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11325)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - windows

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 22, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 22, 2016
@highfive
Copy link

New code was committed to pull request.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 22, 2016

@bors-servo r=nox

@bors-servo
Copy link
Contributor

📌 Commit 38d96c9 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 22, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 38d96c9 with merge 6b03961...

bors-servo pushed a commit that referenced this pull request May 22, 2016
Move sandboxing into the constellation crate.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11325)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 38d96c9 into master May 22, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 22, 2016
@Ms2ger Ms2ger deleted the sandboxing branch May 22, 2016 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants