Include <button type=submit> data whilst constructing the form dataset

[Manishearth]

This makes it possible to close things in github (see
Manishearth/mitochondria#1)

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors

Either:

• There are tests for these changes OR
• These changes do not require tests because _____

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/htmlformelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/htmlbuttonelement.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[Manishearth]

r? @nox

[Manishearth]

I will file a spec bug on this in a while

[Manishearth]

@bors try

[highfive]

New code was committed to pull request.

[Manishearth]

@bors-servo try

[bors-servo]

⌛ Trying commit aaa85de with merge b74cb98...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

[highfive]

New code was committed to pull request.

[nox]

Thanks for your contribution, just some nits to address.

-S-awaiting-review +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

components/script/dom/htmlbuttonelement.rs, line 145 [r1] (raw file):

    /// Steps range from 3.1 to 3.7 (specific to HTMLButtonElement)
    pub fn form_datum(&self, submitter: Option<FormSubmitter>) -> Option<FormDatum> {
        // 3.1: disabled state check is in get_unclean_dataset

Nit: "Step 3.1"

---

components/script/dom/htmlbuttonelement.rs, line 147 [r1] (raw file):

        // 3.1: disabled state check is in get_unclean_dataset

        // 3.1: only run steps if this is the submitter

Nit: "Step 3.1"

---

components/script/dom/htmlbuttonelement.rs, line 160 [r1] (raw file):

        let name = self.Name();

        if name == "" {

Nit: name.is_empty().

---

components/script/dom/htmlbuttonelement.rs, line 167 [r1] (raw file):

        }

        // Step 3.6

AFAICT, this is step 3.9. not 3.6..

---

components/script/dom/htmlbuttonelement.rs, line 161 [r3] (raw file):

        if name == "" {
            // 3.1: Must have a name

Nit: "Step 3.1"

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[highfive]

New code was committed to pull request.

[nox]

@bors-servo r+

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 2 of 2 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[bors-servo]

📌 Commit 90d72c5 has been approved by nox

[bors-servo]

⌛ Testing commit 90d72c5 with merge de79f96...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows