Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor in components/script/dom/htmlanchorelement.rs to #11349
Conversation
…_href accept &Url argument
highfive
commented
May 23, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
highfive
commented
May 23, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 23, 2016
|
I'm sorry, but there isn't any consensus on whether this PR is what we need yet. |
|
Was there discussion of this somewhere? If so, that discussion should be summarized here. |
|
Sorry, I should have followed the reference. Thanks for clarifying. |
|
Sorry, we're going to need to sit on these changes until we resolve the confusion in #11281. |
|
Nobody ever replied in #11281. I don't think there's any point in leaving this open until there's some movement there, unfortunately. |
shuky19 commentedMay 23, 2016
•
edited by larsbergstrom
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidy --fasterdoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Refactor in components/script/dom/htmlanchorelement.rs to make update_href accept &Url argument
This change is