Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CompositorMsg to script_traits. #11364

Merged
merged 2 commits into from May 24, 2016
Merged

Move CompositorMsg to script_traits. #11364

merged 2 commits into from May 24, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 24, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@highfive
Copy link

highfive commented May 24, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs, components/constellation/constellation.rs, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs
@nox
Copy link
Member

nox commented May 24, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2016

📌 Commit f9a8c32 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2016

Testing commit f9a8c32 with merge cd1396f...

bors-servo added a commit that referenced this pull request May 24, 2016
Move CompositorMsg to script_traits.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11364)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2016

@bors-servo bors-servo merged commit f9a8c32 into servo:master May 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:CompositorMsg branch May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.