New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ScriptThread::layout_to_constellation_chan. #11375
Conversation
Heads up! This PR modifies the following files:
|
@bors-servo r+ |
📌 Commit 7f55e70 has been approved by |
🔒 Merge conflict |
☔ The latest upstream changes (presumably #11373) made this pull request unmergeable. Please resolve the merge conflicts. |
Instead, pass it along in NewLayoutInfo when needed.
7f55e70
to
4f893ee
Compare
@bors-servo r=mbrubeck |
📌 Commit 4f893ee has been approved by |
Remove ScriptThread::layout_to_constellation_chan. Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy --faster` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because refactoring Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. Instead, pass it along in NewLayoutInfo when needed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11375) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
Thank you for contributing to Servo! Please replace each
[ ]
by[X]
when the step is complete, and replace__
with appropriate data:./mach build -d
does not report any errors./mach test-tidy --faster
does not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Instead, pass it along in NewLayoutInfo when needed.
This change is