Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to the same Cargo features in all build commands #11378

Merged
merged 1 commit into from May 27, 2016
Merged

Default to the same Cargo features in all build commands #11378

merged 1 commit into from May 27, 2016
+17 −2

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented May 24, 2016 •
edited by larsbergstrom

Fixes #8308 and #7327. r? @larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented May 24, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py, python/servo/testing_commands.py
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 27, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit d106f5f has been approved by larsbergstrom
@mbrubeck mbrubeck force-pushed the mbrubeck:debug-mozjs branch from d106f5f to 7078d95 May 27, 2016
@highfive
Copy link

highfive commented May 27, 2016

New code was committed to pull request.
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 27, 2016

@bors-servo r=larsbergstrom

  • Reverted the gonk change to avoid bitrotting #11474, since it's removing that function anyway.
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit 7078d95 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

⌛ Testing commit 7078d95 with merge 9710d97...
bors-servo added a commit that referenced this pull request May 27, 2016
@bors-servo
Auto merge of #11378 - mbrubeck:debug-mozjs, r=larsbergstrom
9710d97 
Default to the same Cargo features in all build commands

Fixes #8308 and #7327. r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11378)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

💔 Test failed - mac-rel-css
@highfive
Copy link

highfive commented May 27, 2016 

  ▶ CRASH [expected FAIL] /css-flexbox-1_dev/html/flexbox-baseline-multi-item-vert-001.htm
  │ 
  └ Shutting down the Constellation after generating an output file or exit flag specified
@mbrubeck
Default to the same Cargo features in all build commands
Loading status checks…
8587ec4 
Fixes #8308 and #7327.
@mbrubeck mbrubeck force-pushed the mbrubeck:debug-mozjs branch from 7078d95 to 8587ec4 May 27, 2016
@highfive
Copy link

highfive commented May 27, 2016

New code was committed to pull request.
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 27, 2016

@bors-servo r=larsbergstrom

  • Removed some leftover redundant code
  • Filed #11479 for the crash above
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit 8587ec4 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

⌛ Testing commit 8587ec4 with merge 2d49416...
bors-servo added a commit that referenced this pull request May 27, 2016
@bors-servo
Auto merge of #11378 - mbrubeck:debug-mozjs, r=larsbergstrom
Loading status checks…
2d49416 
Default to the same Cargo features in all build commands

Fixes #8308 and #7327. r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11378)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 8587ec4 into servo:master May 27, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@timvandermeij timvandermeij mentioned this pull request May 28, 2016
Closed
@mbrubeck mbrubeck deleted the mbrubeck:debug-mozjs branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mbrubeck @highfive @larsbergstrom @bors-servo
You can’t perform that action at this time.