Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to the same Cargo features in all build commands #11378

Merged
merged 1 commit into from May 27, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -147,7 +147,7 @@ def build(self, target=None, release=False, dev=False, jobs=None,
features=None, android=None, verbose=False, debug_mozjs=False, params=None):
if android is None:
android = self.config["build"]["android"]
features = features or []
features = features or self.servo_features()

opts = params or []

@@ -194,7 +194,7 @@ def build(self, target=None, release=False, dev=False, jobs=None,

self.ensure_bootstrapped(target=target)

if debug_mozjs or self.config["build"]["debug-mozjs"]:
if debug_mozjs:
features += ["script/debugmozjs"]

if features:
@@ -265,6 +265,10 @@ def build_cef(self, jobs=None, verbose=False, release=False):
if release:
opts += ["--release"]

servo_features = self.servo_features()
if servo_features:
opts += ["--features", "%s" % ' '.join("servo/" + x for x in servo_features)]

build_start = time()
with cd(path.join("ports", "cef")):
ret = call(["cargo", "build"] + opts,
@@ -415,6 +415,13 @@ def build_env(self, gonk=False, hosts_file_path=None, target=None):
def servo_crate(self):
return path.join(self.context.topdir, "components", "servo")

def servo_features(self):
"""Return a list of optional features to enable for the Servo crate"""
features = []
if self.config["build"]["debug-mozjs"]:
features += ["script/debugmozjs"]
return features

def android_support_dir(self):
return path.join(self.context.topdir, "support", "android")

@@ -178,6 +178,10 @@ def test_unit(self, test_name=None, package=None):
args += ["-p", "%s_tests" % crate]
args += test_patterns

features = self.servo_features()
if features:
args += ["--features", "%s" % ' '.join(features)]

env = self.build_env()
env["RUST_BACKTRACE"] = "1"

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.