Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake geckolib build dependencies with the same features as Servo by default #11381
Conversation
…efault This reduces the number of things that need to be recompiled when building Geckolib and Servo in the same source tree.
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
May 24, 2016
Make geckolib build dependencies with the same features as Servo by default This reduces the number of things that need to be recompiled when building Geckolib and Servo in the same source tree. This is a bit fragile and will need to be maintained by hand, but it's a nice improvement for developers. r? @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11381) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 24, 2016
Make geckolib build dependencies with the same features as Servo by default This reduces the number of things that need to be recompiled when building Geckolib and Servo in the same source tree. This is a bit fragile and will need to be maintained by hand, but it's a nice improvement for developers. r? @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11381) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@bors-servo p=1 |
bors-servo
added a commit
that referenced
this pull request
May 25, 2016
Make geckolib build dependencies with the same features as Servo by default This reduces the number of things that need to be recompiled when building Geckolib and Servo in the same source tree. This is a bit fragile and will need to be maintained by hand, but it's a nice improvement for developers. r? @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11381) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 24, 2016
•
edited by larsbergstrom
This reduces the number of things that need to be recompiled when building Geckolib and Servo in the same source tree.
This is a bit fragile and will need to be maintained by hand, but it's a nice improvement for developers.
r? @nox
This change is