Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unnecessary information in the rendered PR template #11383

Merged
merged 3 commits into from May 26, 2016
Merged

Hide unnecessary information in the rendered PR template #11383

merged 3 commits into from May 26, 2016

Conversation

@jdm
Copy link
Member

jdm commented May 24, 2016 •
edited by larsbergstrom

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because not part of the build

This change is Reviewable
PULL_REQUEST_TEMPLATE.md Outdated
@@ -1,10 +1,13 @@
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
Replace this paragraph with a description of the changes, then follow the instructions in the next section.

This comment has been minimized.

Sign in to view
@mbrubeck

mbrubeck May 24, 2016 •
edited

Contributor

Maybe this should also be a comment that just says "Enter a description of your changes below this line:" (and then some blank space).

(I think that makes it a little harder to gloss over this step.)
@mbrubeck mbrubeck assigned mbrubeck and unassigned Ms2ger May 24, 2016
@aneeshusa
Copy link
Member

aneeshusa commented May 24, 2016

Same comment as #11340 (comment) - I find that people mostly add their own content at the end of the template instead of at the top.
@jdm
Copy link
Member Author

jdm commented May 24, 2016 •
edited

@aneeshusa While I can believe that, we may be able to influence that decision. I think doing so is useful, since it will address one of @nox's common complaints about the new template.
@aneeshusa
Copy link
Member

aneeshusa commented May 24, 2016

Works for me, although mbrubeck's suggested change would make it much more natural (having to replace existing text is just weird).
@metajack
Copy link
Contributor

metajack commented May 24, 2016

This looks good to me. I think @mbrubeck's suggestion is a good one, but I'm happy to try it this way first if you prefer that. If we see anyone submitting PRs without changing this text, then I think we should definitely make that change.

This is r=me but I didn't r+ it since mbrubeck is the assignee and his suggestion was unaddressed in the comments.
@highfive
Copy link

highfive commented May 24, 2016

New code was committed to pull request.
@jdm
Copy link
Member Author

jdm commented May 24, 2016

@mbrubeck See what you think of my newest text.
@mbrubeck
Copy link
Contributor

mbrubeck commented May 24, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2016

📌 Commit 76cba2a has been approved by mbrubeck
@Ms2ger
Copy link
Contributor

Ms2ger commented May 25, 2016

@bors-servo p=-1
@jdm jdm mentioned this pull request May 25, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2016

☔ The latest upstream changes (presumably #11409) made this pull request unmergeable. Please resolve the merge conflicts.
@metajack
Copy link
Contributor

metajack commented May 25, 2016

OMG. How sad that we can bitrot this :)
jdm added 3 commits May 20, 2016
@jdm
Hide some PR template content
7b17251
@jdm
Separate checklist from PR description.
ac757b4
@jdm
Try to mitigate the risk of unmodified PR descriptions
Loading status checks…
1cfc2c9
@jdm jdm closed this May 25, 2016
@jdm jdm force-pushed the jdm-patch-1 branch from 76cba2a to 4616f63 May 25, 2016
@highfive
Copy link

highfive commented May 25, 2016

New code was committed to pull request.
@jdm jdm reopened this May 25, 2016
@jdm
Copy link
Member Author

jdm commented May 25, 2016

@bors-servo: r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2016

📌 Commit 1cfc2c9 has been approved by mbrubeck
@jdm
Copy link
Member Author

jdm commented May 25, 2016

@bors-servo: p=-1
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2016

⌛ Testing commit 1cfc2c9 with merge a2874ef...
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11383 - servo:jdm-patch-1, r=mbrubeck
a2874ef 
Hide unnecessary information in the rendered PR template

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:-->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because not part of the build

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2016

💔 Test failed - mac-rel-css
@mbrubeck
Copy link
Contributor

mbrubeck commented May 26, 2016

@bors-servo retry

mac1
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2016

⌛ Testing commit 1cfc2c9 with merge b898550...
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11383 - servo:jdm-patch-1, r=mbrubeck
Loading status checks…
b898550 
Hide unnecessary information in the rendered PR template

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:-->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because not part of the build

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 1cfc2c9 into master May 26, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the jdm-patch-1 branch May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@jdm @aneeshusa @metajack @highfive @mbrubeck @bors-servo @Ms2ger
You can’t perform that action at this time.