Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Android APK building (packaging) #11406
Merged
Conversation
I missed this syntax error during my review, and we don't check that packaging succeeds in regular build suite, but only as a Nightly build.
|
@bors-servo r+ I agree we should run this on all auto builds. |
|
|
|
@bors-servo p=-1 |
|
|
bors-servo
added a commit
that referenced
this pull request
May 27, 2016
…brubeck Fix Android APK building (packaging) Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy --faster` does not report any errors - [ ] These changes help with #10339. Either: - [x] There are tests for these changes (android-nightly builder) OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. I missed this syntax error during my review, and we don't check that packaging succeeds in regular build suite, but only as a Nightly build. @larsbergstrom should we run the packaging as part of the regular build? I think it is important that this continue to stay working, especially with #9918. In that case, the only difference with the nightly builder is whether or not to upload to S3. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11406) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Jun 20, 2016
Install Android build tools for cross compilation The Android build tools are required for building an APK. They are versioned separately from the SDK and do not have a version requirement - best practice is to use the latest (stable) release. After servo/servo#11406 landed, I forced an android-nightly build, which now gets further but still fails. The new failure is http://build.servo.org/builders/android-nightly/builds/60/steps/shell_1/logs/stdio, so install the build tools to fix this. Edit: relevant error for posterity: ``` BUILD FAILED /home/servo/android/sdk/current/tools/ant/build.xml:483: SDK does not have any Build Tools installed. ``` Another step for servo/servo#10339. I think this would benefit from #374 - I had a lot of errors trying to get the android tool to install the build tools where blowing away the directory fixed it. I think the --all parameter should take care of it, but I'd like to be more sure. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/388) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Jun 23, 2016
…bergstrom Test packaging on android builder Our android-nightly builder has been busted for a long time, which meant our packaging code was not being exercised. Also, the nightly builder only runs once a day instead of on each build, which recently allowed a regression to slip in due to an uncaught syntax error. To prevent future regressions, test packaging on the android builder, which runs on try and auto builds. See servo/servo#11406 for the bug. This should not be merged until that fix is merged and android-nightly has had a chance to run, to ensure that packaging is no longer broken. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/386) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMay 25, 2016
•
edited by larsbergstrom
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidy --fasterdoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
I missed this syntax error during my review, and we don't check that
packaging succeeds in regular build suite, but only as a Nightly build.
@larsbergstrom should we run the packaging as part of the regular build? I think it is important that this continue to stay working, especially with #9918. In that case, the only difference with the nightly builder is whether or not to upload to S3.
This change is