Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android APK building (packaging) #11406

Merged
merged 1 commit into from May 27, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix Android APK building (packaging)

I missed this syntax error during my review, and we don't check that
packaging succeeds in regular build suite, but only as a Nightly build.
  • Loading branch information
aneeshusa committed May 25, 2016
commit fa33eefcbd58c2d702394d1ac2e1786893740db3
@@ -30,7 +30,7 @@ fn main() {
// Get the target android platform from ANDROID_PLATFORM env. Expecting "android-{version}"
let android_platform = env::var("ANDROID_PLATFORM")
.ok()
.expect("Please set the ANDROID_PLATFORM environment variable")
.expect("Please set the ANDROID_PLATFORM environment variable");

// Get the standalone NDK path from NDK_STANDALONE env.
// let standalone_path = env::var("NDK_STANDALONE").ok().unwrap_or("/opt/ndk_standalone".to_string());
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.