Remove the script listener thread. #11410

Ms2ger · 2016-05-25T08:47:32Z

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

./mach build -d does not report any errors
./mach test-tidy --faster does not report any errors
These changes fix #__ (github issue number if applicable).

Either:

There are tests for these changes OR
These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

This change is

highfive · 2016-05-25T08:47:35Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/pipeline.rs, components/constellation/constellation.rs
@KiChjang: components/script/dom/document.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script_traits/lib.rs

highfive · 2016-05-25T08:47:36Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

nox · 2016-05-25T08:57:46Z

@bors-servo r+

Previously, highfive wrote…

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

Reviewed 8 of 8 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

bors-servo · 2016-05-25T08:57:47Z

📌 Commit ef30063 has been approved by nox

bors-servo · 2016-05-25T10:24:59Z

☔ The latest upstream changes (presumably #11373) made this pull request unmergeable. Please resolve the merge conflicts.


        Remove the script listener thread (fixes #11345).

We needed a separate thread in the chrome process because communication to the compositor is done through a trait object, and cross-process virtual calls are forbidden. Also, the fact that these messages are ultimately handled by the compositor is an implementation detail; conceptually, the relevant constellation is supposed to handle these messages. So instead, the script thread will now send the messages to the constellation, which will ask the compositor to handle them.


        Merge PrivilegedPipelineContent::{start_all, start_paint_thread}.

They now do the same thing.

Ms2ger · 2016-05-25T10:58:16Z

@bors-servo r=nox

bors-servo · 2016-05-25T10:58:18Z

📌 Commit e7f75ca has been approved by nox

Ms2ger · 2016-05-25T10:59:59Z

@bors-servo p=1

Blocks #11375

bors-servo · 2016-05-25T11:10:18Z

⌛ Testing commit e7f75ca with merge 1640ade...


        Auto merge of #11410 - Ms2ger:script-listener-thread, r=nox

Remove the script listener thread. Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy --faster` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because refactoring Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11410)

bors-servo · 2016-05-25T11:43:31Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-25T11:43:33Z

  ▶ TIMEOUT [expected OK] /html/dom/reflection-embedded.html
  │ 
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ stack backtrace:
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOfthread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, &#39; panicked at &#39;../src/libstd/rand/mod.rs:159could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │ 
  │    1:        0x10bbf4d28 - std::sys</span><span class="stdout">::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9f</span><span class="stdout">b - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10b</span><span class="stdout">bfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10b9c139f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x10b9c11dc - rand::thread_rng::he394b446ab605489
  │   10:        0x10b9c00c2 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x10a52676d - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  │   18:     0x7fff8e157fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10bbf4d28 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbfb275 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbfae8e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b948872 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbe2332 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbfb836 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe3c28 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbfbca9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x10bbe293c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x10a4de10c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x10a524e34 - net::http_loader::load::h4cdeddfa5dca9e93
  │   12:        0x10a52136c - std::panicking::try::call::h2f55588c0568c703
  │   13:        0x10bbfe9fb - __rust_try
  │   14:        0x10bbfe995 - __rust_maybe_catch_panic
  │   15:        0x10a523374 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::ha5012a14880088fa
  │   16:        0x10bbfa1d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8e158059 - _pthread_body
  └   18:     0x7fff8e157fd6 - _pthread_start

nox · 2016-05-25T11:56:37Z

@bors-servo retry #11100

bors-servo · 2016-05-25T12:58:28Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-05-25T13:38:15Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned asajeffrey May 25, 2016

highfive assigned nox and unassigned asajeffrey May 25, 2016

Ms2ger added 2 commits May 25, 2016

Merge PrivilegedPipelineContent::{start_all, start_paint_thread}.

Loading status checks…

e7f75ca

They now do the same thing.

Ms2ger force-pushed the Ms2ger:script-listener-thread branch from ef30063 to e7f75ca May 25, 2016

bors-servo merged commit e7f75ca into servo:master May 25, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

Ms2ger deleted the Ms2ger:script-listener-thread branch May 25, 2016

servo / servo

Remove the script listener thread. #11410

Remove the script listener thread. #11410

Ms2ger commented May 25, 2016 •

edited by larsbergstrom

highfive commented May 25, 2016

highfive commented May 25, 2016

nox commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

Ms2ger commented May 25, 2016

bors-servo commented May 25, 2016

Ms2ger commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

highfive commented May 25, 2016

nox commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

servo / servo

Join GitHub today

Remove the script listener thread. #11410

Remove the script listener thread. #11410

Conversation

Ms2ger commented May 25, 2016 • edited by larsbergstrom

highfive commented May 25, 2016

highfive commented May 25, 2016

nox commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

Ms2ger commented May 25, 2016

bors-servo commented May 25, 2016

Ms2ger commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

highfive commented May 25, 2016

nox commented May 25, 2016

bors-servo commented May 25, 2016

bors-servo commented May 25, 2016

Ms2ger commented May 25, 2016 •

edited by larsbergstrom