Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce a compositing_traits crate. #11419
Conversation
|
This was an experiment; if people feel it isn't much of an improvement, I'd be happy to drop it. |
highfive
commented
May 25, 2016
|
New code was committed to pull request. |
|
The normal motivation for this split is to allow more crates to compile in parallel. Which crates does this now allow to compile earlier, and how does it affect build time? |
|
This allows compositing and constellation to compile in parallel, which are the final step before servo and after layout. Compositing is likely able to build slightly earlier in the process, too. |
|
This looks good. It needs squashing and the ports/cef and ports/gonk and lockfiles also need updating, or at least seem like they should since they currently depend on compositing crate. r=me with those changes.
|
|
|
|
It looks like @metajack said it was all good, and then it bitrotted. Should it be rebased? |
|
Closing this given http://logs.glob.uno/?c=mozilla%23servo#c568125. |
Ms2ger commentedMay 25, 2016
•
edited by larsbergstrom
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidy --fasterdoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
This change is