Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a compositing_traits crate. #11419

Closed
wants to merge 2 commits into from
Closed

Introduce a compositing_traits crate. #11419

wants to merge 2 commits into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 25, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@Ms2ger Ms2ger force-pushed the compositing-traits branch from 0bcbb30 to 8419069 May 25, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 25, 2016

This was an experiment; if people feel it isn't much of an improvement, I'd be happy to drop it.

@Ms2ger Ms2ger force-pushed the compositing-traits branch from 8419069 to 51f3b3f May 25, 2016
@highfive
Copy link

highfive commented May 25, 2016

New code was committed to pull request.

@metajack
Copy link
Contributor

metajack commented May 25, 2016

The normal motivation for this split is to allow more crates to compile in parallel. Which crates does this now allow to compile earlier, and how does it affect build time?

@jdm
Copy link
Member

jdm commented May 25, 2016

This allows compositing and constellation to compile in parallel, which are the final step before servo and after layout. Compositing is likely able to build slightly earlier in the process, too.

@metajack
Copy link
Contributor

metajack commented May 25, 2016

This looks good. It needs squashing and the ports/cef and ports/gonk and lockfiles also need updating, or at least seem like they should since they currently depend on compositing crate. r=me with those changes.

Previously, jdm (Josh Matthews) wrote…

This allows compositing and constellation to compile in parallel, which are the final step before servo and after layout. Compositing is likely able to build slightly earlier in the process, too.


Reviewed 7 of 7 files at r1, 15 of 15 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

The latest upstream changes (presumably #11329) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle
Copy link
Contributor

notriddle commented Sep 12, 2016

It looks like @metajack said it was all good, and then it bitrotted. Should it be rebased?

@jdm
Copy link
Member

jdm commented Nov 24, 2016

@jdm jdm closed this Nov 24, 2016
@Manishearth Manishearth deleted the compositing-traits branch Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.