Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement meta referrer policy delivery (2) #11422

Closed
wants to merge 2 commits into from
Closed

Implement meta referrer policy delivery (2) #11422

wants to merge 2 commits into from

Conversation

@rebstar6
Copy link
Contributor

rebstar6 commented May 25, 2016 •
edited by larsbergstrom

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #10311 (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

This change is Reviewable
@highfive
Copy link

highfive commented May 25, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy/tidy.py
  • @jgraham: tests/wpt/include.ini
  • @KiChjang: components/net/http_loader.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/webidls/Document.webidl, components/script/dom/htmlmetaelement.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/document.rs, components/script/dom/htmliframeelement.rs
@rebstar6
Copy link
Contributor Author

rebstar6 commented May 25, 2016

@nox - new PR for #11238
@KiChjang KiChjang mentioned this pull request May 25, 2016
Closed
3 of 5 tasks complete
@SimonSapin SimonSapin assigned jdm and unassigned SimonSapin May 25, 2016
@jdm jdm assigned nox and unassigned jdm May 25, 2016
@nox nox mentioned this pull request May 25, 2016
Merged
@nox
Copy link
Member

nox commented May 25, 2016 •
edited

@rebstar6 To further ease our reviewing round-trips, I took the testing part and made a separate PR, see #11429.
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
27d61fa 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
7ba96cc 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=<try>
c9f0cac 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
e8607dc 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
76ab412 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 26, 2016
@bors-servo
Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
Loading status checks…
c432e9a 
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

☔ The latest upstream changes (presumably #11429) made this pull request unmergeable. Please resolve the merge conflicts.
rebstar6 added 2 commits May 21, 2016
@rebstar6
Add meta-referrer support
eaf4485
@rebstar6
Remove expected failures in referrer policy tests
Loading status checks…
9e5f9da
@rebstar6 rebstar6 force-pushed the rebstar6:refPol3 branch from 27c93b6 to 9e5f9da May 27, 2016
@rebstar6
Copy link
Contributor Author

rebstar6 commented May 27, 2016

@nox cool - just got rid of those commits here and added in one taking out the expected failures. Should be good for review :)
@nox
Copy link
Member

nox commented May 27, 2016

Excuse me @rebstar6, think you could make a new PR again? ^^' Reviewable is not really able to forget all the files that you initially added for the tests if the first revisions.
@rebstar6
Copy link
Contributor Author

rebstar6 commented May 27, 2016

Haha can do - #11468
@nox nox closed this May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement referrer policy
6 participants
@rebstar6 @highfive @nox @bors-servo @jdm @SimonSapin
You can’t perform that action at this time.