Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPartially enable referrer-policy tests with some modifications #11429
Conversation
highfive
commented
May 25, 2016
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
|
@bors-servo: r+ |
|
|
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
|
|
The mac-rel-css build hit an infrastructure issue, but mac-rel-wpt shows a large number of timeouts in the referrer-policy tests. |
highfive
commented
May 26, 2016
|
New code was committed to pull request. |
|
I had forgotten an async xhr in common.js, this is fixed now. @bors-servo r=jdm |
|
|
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
Damn it, this failed again. http://build.servo.org/builders/linux-rel/builds/1266 Weirdly I can't reproduce locally. :( |
|
|
highfive
commented
May 26, 2016
|
highfive
commented
May 26, 2016
|
New code was committed to pull request. |
|
I think the paths were incorrect in @bors-servo try |
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
@jdm These errors make no sense:
The only place where there is a |
|
So the tests were failing because all tests run in the same Python process. I renamed 'subresource' to 'mozresource' and everything passes now. @bors-servo r=jdm |
|
|
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
|
highfive
commented
May 26, 2016
|
|
@bors-servo retry #11276 |
|
@bors-servo p=1 |
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
|
highfive
commented
May 26, 2016
|
|
@bors-servo: retry |
|
|
|
|
highfive
commented
May 26, 2016
|
|
@bors-servo: retry |
|
I wonder if the extra set of new tests causes cors-redirect.html to run at the same time as some other tests that cause a bunch of file handles to be consumed, leading to the timeout each time? |
|
|
|
|
highfive
commented
May 26, 2016
|
|
This will need to wait until #11447 merges before we try again. |
Disable redirect-origin.html on OS X Disable a test that started permanently timing out in #11429. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because disabling a test <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11447) <!-- Reviewable:end -->
|
@bors-servo: retry |
Partially enable referrer-policy tests with some modifications This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429) <!-- Reviewable:end -->
|
|
nox commentedMay 25, 2016
•
edited by larsbergstrom
This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.
This change is