11402 implement window alert

[ab22]

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #11402

Either:

• There are tests for these changes OR
• These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

---

This change is

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/window.rs, components/script/dom/webidls/Window.webidl

[KiChjang]

Please squash your commits into one. r=me when post squash.

[highfive]

New code was committed to pull request.

[KiChjang]

@bors-servo r+

Thanks!

[bors-servo]

📌 Commit f14303d has been approved by KiChjang

[ab22]

@KiChjang Thanks for approving .. was waiting for the checks to pass before @ you :P

[KiChjang]

@ab22 The "r=me" comment is meant for other reviewers. @bors-servo is very specific about who he listens to.

[bors-servo]

⌛ Testing commit f14303d with merge c8bf62e...

[bors-servo]

💔 Test failed - mac-rel-wpt

[highfive]

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  │ FAIL [expected PASS] Window interface: operation alert()
  │   → assert_own_property: global object missing non-static operation expected property "alert" missing
  │ 
  │ IdlInterface.prototype.test_member_operation/<@http://web-platform.test:8000/resources/idlharness.js:1179:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ IdlInterface.prototype.test_member_operation@http://web-platform.test:8000/resources/idlharness.js:1137:5
  │ IdlInterface.prototype.test_members@http://web-platform.test:8000/resources/idlharness.js:1361:21
  │ IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:693:5
  │ IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:358:9
  └ window.onload@http://web-platform.test:8000/html/dom/interfaces.html:180:3

[cbrewster]

Looks like the same issue as #11407 (comment) I guess there is an issue with the codegen.

[KiChjang]

This change here needs to be reverted.

[KiChjang]

You'll need to create some new tests under tests/wpt/web-platform-tests/html/browsers/the-window-object/browser-interface-elements/alert.html.

[jdm]

What sort of test do you have in mind? Alert seems challenging to me, since it's supposed to have a modal UI.

[cbrewster]

@jdm @KiChjang Maybe add to tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html? Just add a new iframe that calls alert with no parameters, make sure we get the mozbrowser event and the message is an empty string

[jdm]

Good idea!

[highfive]

New code was committed to pull request.

[ab22]

Pushed the new test and reverted the previous mentioned change.

Again: ./mach build -d && ./mach test-tidy does not report any errors and ./mach test-wpt tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html shows all tests as PASS.

[KiChjang]

@bors-servo r+

[bors-servo]

📌 Commit d72dbb6 has been approved by KiChjang

[bors-servo]

⌛ Testing commit d72dbb6 with merge 6d0c420...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows