WIP: Fixes #11407: Implement Window.status

[catchmrbharath]

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #11407 (github issue number if applicable).

Either:

• There are tests for these changes OR
• These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/window.rs, components/script/dom/webidls/Window.webidl

[catchmrbharath]

@Ms2ger mentioned in IRC that the tests won't work because of problems in codegen. I am reverting the test change back to FAIL.

I am not sure how to test these changes though. Any ideas ? @jdm

[nox]

-S-awaiting-review +S-needs-code-changes +C-needs-test

Previously, catchmrbharath wrote…

@Ms2ger mentioned in IRC that the tests won't work because of problems in codegen. I am reverting the test change back to FAIL.

I am not sure how to test these changes though. Any ideas ? @jdm

---

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/script/dom/window.rs, line 835 [r1] (raw file):

    fn Status(&self) -> DOMString {
        self.status.borrow_mut().clone()

Just .borrow() is enough here.

---

Comments from Reviewable

[cbrewster]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

components/script/dom/window.rs, line 834 [r1] (raw file):

    }

    fn Status(&self) -> DOMString {

A comment should be added above this with a link to the spec: https://html.spec.whatwg.org/multipage/#dom-window-status

---

components/script/dom/window.rs, line 838 [r1] (raw file):

    }

    fn SetStatus(&self, status: DOMString) {

Same thing as above (same spec link aswell)

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[nox]

-C-needs-test -S-awaiting-review +C-has-test +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

tests/wpt/web-platform-tests/html/browsers/the-window-object/browser-interface-elements/status.html, line 6 [r2] (raw file):

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="help" href="https://html.spec.whatwg.org/multipage/browsers.html#dom-window-status">

Nit: remove browsers.html from the link.

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[nox]

-S-awaiting-review +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[catchmrbharath]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

tests/wpt/web-platform-tests/html/browsers/the-window-object/browser-interface-elements/status.html, line 6 [r2] (raw file):

Previously, nox (Anthony Ramine) wrote…

Nit: remove browsers.html from the link.

You mean remove the whole link?

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[nox]

-S-awaiting-review +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

tests/wpt/web-platform-tests/html/browsers/the-window-object/browser-interface-elements/status.html, line 6 [r2] (raw file):

Previously, catchmrbharath (Bharath Mankalale) wrote…

You mean remove the whole link?

No, remove `browsers.html`, so that the link is the same as in the Rust code comment. The links with the filenames can change, while the others aren't supposed to.

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[nox]

@bors-servo r+

Thanks for your contribution!

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[bors-servo]

📌 Commit a4d9a1d has been approved by nox

[bors-servo]

⌛ Testing commit a4d9a1d with merge d890453...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows