Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate BrowserElement.webidl #11451
Update BrowserElement.webidl #11451
Conversation
highfive
commented
May 26, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon. |
highfive
commented
May 26, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 26, 2016
|
It appears that you haven't compiled the changes. Please do so before making a pull request :) |
|
@jdm I am new to this, do you mean compile and re upload? |
|
@Coder206 your change the |
|
When you've made the necessary changes and fixed the tests from #11450, you can commit your changes and push them to this branch and reopen the pull request. |
|
@jdm and @ConnorGBrewster So you just want me to try to compile and ensure it works on my end before sending it off? |
|
@Coder206 Yes, that makes reviewing the code changes much less effort for us. |
|
@jdm Sorry for the inconvenience, won't happen again from me. |
Coder206 commentedMay 26, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is