Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BrowserElement.webidl #11451

Closed
wants to merge 1 commit into from
Closed

Update BrowserElement.webidl #11451

wants to merge 1 commit into from

Conversation

@Coder206
Copy link
Contributor

Coder206 commented May 26, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented May 26, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.

@highfive
Copy link

highfive commented May 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/BrowserElement.webidl
@highfive
Copy link

highfive commented May 26, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented May 26, 2016

It appears that you haven't compiled the changes. Please do so before making a pull request :)

@jdm jdm closed this May 26, 2016
@Coder206
Copy link
Contributor Author

Coder206 commented May 26, 2016

@jdm I am new to this, do you mean compile and re upload?

@cbrewster
Copy link
Member

cbrewster commented May 26, 2016

@Coder206 your change the webidl file will require some more changes elsewhere, when you compile you should get some errors, those errors will need to be fixed.

@jdm
Copy link
Member

jdm commented May 26, 2016

When you've made the necessary changes and fixed the tests from #11450, you can commit your changes and push them to this branch and reopen the pull request.

@Coder206
Copy link
Contributor Author

Coder206 commented May 26, 2016

@jdm and @ConnorGBrewster So you just want me to try to compile and ensure it works on my end before sending it off?

@jdm
Copy link
Member

jdm commented May 26, 2016

@Coder206 Yes, that makes reviewing the code changes much less effort for us.

@Coder206
Copy link
Contributor Author

Coder206 commented May 26, 2016

@jdm Sorry for the inconvenience, won't happen again from me.

@Coder206 Coder206 deleted the Coder206:patch-1 branch Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.