Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the LayoutChan type. #11463

Merged
merged 1 commit into from May 27, 2016
Merged

Remove the LayoutChan type. #11463

merged 1 commit into from May 27, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 27, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because refactoring

It is a pointless abstraction.

This change is Reviewable
@highfive
Copy link

highfive commented May 27, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/node.rs, components/script/dom/htmlstyleelement.rs, components/script/layout_interface.rs, components/script/dom/bindings/trace.rs, components/script/script_thread.rs, components/script/dom/window.rs
@highfive
Copy link

highfive commented May 27, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented May 27, 2016

@bors-servo r+

Previously, highfive wrote…

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit 3984d21 has been approved by nox
@highfive highfive assigned nox and unassigned pcwalton May 27, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

☔ The latest upstream changes (presumably #11329) made this pull request unmergeable. Please resolve the merge conflicts.
@Ms2ger
Remove the LayoutChan type.
Loading status checks…
e94f3d4 
It is a pointless abstraction.
@Ms2ger Ms2ger force-pushed the Ms2ger:LayoutChan branch from 3984d21 to e94f3d4 May 27, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 27, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit e94f3d4 has been approved by nox
bors-servo added a commit that referenced this pull request May 27, 2016
@bors-servo
Auto merge of #11463 - Ms2ger:LayoutChan, r=nox
Loading status checks…
d160f8c 
Remove the LayoutChan type.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

It is a pointless abstraction.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11463)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

⌛ Testing commit e94f3d4 with merge d160f8c...
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit e94f3d4 into servo:master May 27, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:LayoutChan branch May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @pcwalton
You can’t perform that action at this time.