Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to improve apperance on dark background #11473

Closed
wants to merge 1 commit into from

Conversation

@ojab
Copy link

ojab commented May 27, 2016

Before/after comparison on Mac OS X dock w/ dark theme: https://imgur.com/a/atI6l


This change is Reviewable

@highfive
Copy link

highfive commented May 27, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@mbrubeck
Copy link
Contributor

mbrubeck commented May 27, 2016

I'm no graphic designer, but my first impression is that this is a little too bold. Would a soft glow work, like a light-colored drop shadow?

@highfive
Copy link

highfive commented May 27, 2016

New code was committed to pull request.

@ojab
Copy link
Author

ojab commented May 27, 2016

Updated the PR, new image is the bottom one: https://imgur.com/a/QJfKN.

@ojab
Copy link
Author

ojab commented May 27, 2016

…and removed border on doge (so only sprocket has border), last one is top one: http://imgur.com/a/JkclL.

@highfive
Copy link

highfive commented May 27, 2016

New code was committed to pull request.

@mbrubeck
Copy link
Contributor

mbrubeck commented May 31, 2016

I think I'd prefer a glow or drop-shadow that is behind the logo, so that it doesn't change the look at all on a white background. Right now it makes the Rust "gear" look a little fuzzy-edged at certain sizes especially on light backgrounds, and creates some odd effects where the white lines stop, like here:

closeup

Here's an example with a white drop-shadow against a dark background:

glow

The same thing might work well with a sharper outline placed behind the image, for a less glowy effect.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 1, 2016

I like @mbrubeck's suggestion, provided that it also looks good on a light background.

Adding @zmike, the original creator of the icon, for his thoughts.

@zmike
Copy link
Contributor

zmike commented Jun 1, 2016

After examining the issue further and with a number of unmentioned background colors (e.g., black http://i.imgur.com/HstiKls.png), I think this is a good solution:

DELETED

It's a bit more subtle than the other images posted here, allowing the emphasis to remain on the logo itself rather than having the eyes drawn to the outline effect.

EDIT: I deleted the first one because I noticed some artifacts from the original logo that I wanted to clean up. The updated version:

http://i.imgur.com/uDgaEyT.png

@jdm
Copy link
Member

jdm commented Jun 8, 2016

We should make a decision here :)

@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 8, 2016

As the randomly-selected reviewer, I propose checking in @zmike's version. It's very similar to @ojab's latest, but fixes some minor artifacts and fuzziness. Any objections?

And by the way, thank you @ojab for filing this issue; any of these are a big improvement on dark backgrounds!

@ojab
Copy link
Author

ojab commented Jun 8, 2016

@zmike's version is too subtle and barely visible on HiDPI screen w/ native resolution (i. e. not 2x) here, but I assume that it's not so common setup
It looks better in default setup, so I think that it's the right choice.

@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 8, 2016

@zmike, want to file a new PR for that?

@Coder206
Copy link
Contributor

Coder206 commented Jun 21, 2016

Please keep me posted on this. I am planning on implementing this on Windows, a requirement is to have it converted to ".ico", so I would like to use this new icon :)

bors-servo added a commit that referenced this pull request Jun 21, 2016
Add a border to the logo to differentiate from background color.

By @zmike from #11473 (comment).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11814)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…background color (from jdm:fancy-logo); r=metajack

By zmike from servo/servo#11473 (comment).

Source-Repo: https://github.com/servo/servo
Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2

UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…background color (from jdm:fancy-logo); r=metajack

By zmike from servo/servo#11473 (comment).

Source-Repo: https://github.com/servo/servo
Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2

UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…background color (from jdm:fancy-logo); r=metajack

By zmike from servo/servo#11473 (comment).

Source-Repo: https://github.com/servo/servo
Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2

UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.