Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd border to improve apperance on dark background #11473
Conversation
highfive
commented
May 27, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
|
I'm no graphic designer, but my first impression is that this is a little too bold. Would a soft glow work, like a light-colored drop shadow? |
highfive
commented
May 27, 2016
|
New code was committed to pull request. |
|
Updated the PR, new image is the bottom one: https://imgur.com/a/QJfKN. |
|
…and removed border on doge (so only sprocket has border), last one is top one: http://imgur.com/a/JkclL. |
highfive
commented
May 27, 2016
|
New code was committed to pull request. |
|
I think I'd prefer a glow or drop-shadow that is behind the logo, so that it doesn't change the look at all on a white background. Right now it makes the Rust "gear" look a little fuzzy-edged at certain sizes especially on light backgrounds, and creates some odd effects where the white lines stop, like here: Here's an example with a white drop-shadow against a dark background: The same thing might work well with a sharper outline placed behind the image, for a less glowy effect. |
|
After examining the issue further and with a number of unmentioned background colors (e.g., black http://i.imgur.com/HstiKls.png), I think this is a good solution: DELETED It's a bit more subtle than the other images posted here, allowing the emphasis to remain on the logo itself rather than having the eyes drawn to the outline effect. EDIT: I deleted the first one because I noticed some artifacts from the original logo that I wanted to clean up. The updated version: |
|
We should make a decision here :) |
|
@zmike's version is too subtle and barely visible on HiDPI screen w/ native resolution (i. e. not 2x) here, but I assume that it's not so common setup |
|
@zmike, want to file a new PR for that? |
|
Please keep me posted on this. I am planning on implementing this on Windows, a requirement is to have it converted to ".ico", so I would like to use this new icon :) |
Add a border to the logo to differentiate from background color. By @zmike from #11473 (comment). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11814) <!-- Reviewable:end -->
…background color (from jdm:fancy-logo); r=metajack By zmike from servo/servo#11473 (comment). Source-Repo: https://github.com/servo/servo Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2 UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56
…background color (from jdm:fancy-logo); r=metajack By zmike from servo/servo#11473 (comment). Source-Repo: https://github.com/servo/servo Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2 UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56
…background color (from jdm:fancy-logo); r=metajack By zmike from servo/servo#11473 (comment). Source-Repo: https://github.com/servo/servo Source-Revision: 9dbf7b413e5c206b8dcf0c6b8bccb420313e32e2 UltraBlame original commit: a70addd6bcdcfaa45dca213b7fa7a6af9e026b56


ojab commentedMay 27, 2016
•
edited by larsbergstrom
Before/after comparison on Mac OS X dock w/ dark theme: https://imgur.com/a/atI6l
This change is