Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the gonk port #11474

Merged
merged 1 commit into from May 28, 2016
Merged

Remove the gonk port #11474

merged 1 commit into from May 28, 2016

Conversation

larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented May 27, 2016 •
edited

This removes the code and support infrastructure for the gonk port.

r? @metajack

  • [x ] ./mach build -d does not report any errors
  • [x ] ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • [ x] These changes do not require tests because there are no tests

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy/tidy.py, python/servo/devenv_commands.py, python/servo/command_base.py, python/servo/build_commands.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 27, 2016
@jdm jdm added the S-needs-rebase There are merge conflict errors. label May 27, 2016
@jdm jdm removed the S-needs-rebase There are merge conflict errors. label May 27, 2016
@metajack
Copy link
Contributor

You missed README.md. Otherwise r=me.

Previously, highfive wrote…

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy/tidy.py, python/servo/devenv_commands.py, python/servo/command_base.py, python/servo/build_commands.py

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@larsbergstrom
Copy link
Contributor Author

@bors-servo r=metajack

@highfive
Copy link

New code was committed to pull request.

@bors-servo
Copy link
Contributor

📌 Commit 036f544 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 27, 2016
@mbrubeck mbrubeck mentioned this pull request May 27, 2016
Merged
@bors-servo
Copy link
Contributor

🔒 Merge conflict

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #11472) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 28, 2016
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 28, 2016
@larsbergstrom
Copy link
Contributor Author

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

📌 Commit 02c7e06 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels May 28, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 02c7e06 with merge e3b2d6a...

bors-servo pushed a commit that referenced this pull request May 28, 2016
Auto merge of #11474 - larsbergstrom:remove_gonk, r=metajack
e3b2d6a 
Remove the gonk port

<!-- Please describe your changes on the following line: -->
This removes the code and support infrastructure for the gonk port.

r? @metajack
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [x ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ x] These changes do not require tests because there are no tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11474)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 02c7e06 into servo:master May 28, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 28, 2016
This was referenced May 28, 2016
Merged
Merged
Merged
@larsbergstrom larsbergstrom deleted the remove_gonk branch September 29, 2016 10:41
xfq added a commit to xfq/servo.org that referenced this pull request Oct 30, 2016
@xfq
Update the platforms Servo currently supports
a1aae4a 
Apple rebranded OS X to macOS; the gonk port was removed in servo/servo#11474.
@xfq xfq mentioned this pull request Oct 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@larsbergstrom @highfive @metajack @bors-servo @jdm