Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gonk port #11474

Merged
merged 1 commit into from May 28, 2016
Merged

Remove the gonk port #11474

merged 1 commit into from May 28, 2016

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 27, 2016 •
edited

This removes the code and support infrastructure for the gonk port.

r? @metajack

  • [x ] ./mach build -d does not report any errors
  • [x ] ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • [ x] These changes do not require tests because there are no tests

This change is Reviewable
@highfive
Copy link

highfive commented May 27, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy/tidy.py, python/servo/devenv_commands.py, python/servo/command_base.py, python/servo/build_commands.py
@larsbergstrom larsbergstrom force-pushed the larsbergstrom:remove_gonk branch from b66e655 to 1d5c01e May 27, 2016
@metajack
Copy link
Contributor

metajack commented May 27, 2016

You missed README.md. Otherwise r=me.

Previously, highfive wrote…

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy/tidy.py, python/servo/devenv_commands.py, python/servo/command_base.py, python/servo/build_commands.py

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@larsbergstrom larsbergstrom force-pushed the larsbergstrom:remove_gonk branch from 1d5c01e to 036f544 May 27, 2016
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented May 27, 2016

@bors-servo r=metajack
@highfive
Copy link

highfive commented May 27, 2016

New code was committed to pull request.
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

📌 Commit 036f544 has been approved by metajack
@mbrubeck mbrubeck mentioned this pull request May 27, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2016

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2016

☔ The latest upstream changes (presumably #11472) made this pull request unmergeable. Please resolve the merge conflicts.
@larsbergstrom
Remove the gonk port
Loading status checks…
02c7e06
@larsbergstrom larsbergstrom force-pushed the larsbergstrom:remove_gonk branch from 036f544 to 02c7e06 May 28, 2016
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented May 28, 2016

@bors-servo r=metajack
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2016

📌 Commit 02c7e06 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2016

⌛ Testing commit 02c7e06 with merge e3b2d6a...
bors-servo added a commit that referenced this pull request May 28, 2016
@bors-servo
Auto merge of #11474 - larsbergstrom:remove_gonk, r=metajack
Loading status checks…
e3b2d6a 
Remove the gonk port

<!-- Please describe your changes on the following line: -->
This removes the code and support infrastructure for the gonk port.

r? @metajack
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [x ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ x] These changes do not require tests because there are no tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11474)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 02c7e06 into servo:master May 28, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced May 28, 2016
Merged
Merged
Merged
@larsbergstrom larsbergstrom deleted the larsbergstrom:remove_gonk branch Sep 29, 2016
xfq added a commit to xfq/servo.org that referenced this pull request Oct 30, 2016
@xfq
Update the platforms Servo currently supports
a1aae4a 
Apple rebranded OS X to macOS; the gonk port was removed in servo/servo#11474.
@xfq xfq mentioned this pull request Oct 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@larsbergstrom @highfive @metajack @bors-servo @jdm
You can’t perform that action at this time.