rename

[rafaqtro]

rename of page_fetch_complete and handle_page_fetch_complete for page_headers_available and handle_page_headers_available .

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #11418 (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because _____

---

This change is

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/script_thread.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[jdm]

@rafaqtro It doesn't appear that you have compiled these changes, since no code that calls page_fetch_complete was updated.

[highfive]

New code was committed to pull request.

[emilio]

Hi, this looks a lot better now! :)

Could you align the arguments for those functions to the same column, please?
This is ready to land with that.

Thanks for doing this! :-)

-S-awaiting-review +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

components/script/script_thread.rs, line 481 [r1] (raw file):

impl ScriptThread {
    pub fn page_headers_available(id: &PipelineId, subpage: Option<&SubpageId>, metadata: Option<Metadata>)
                               -> Option<ParserRoot> {

nit: Could you align this with the parenthesis, as it was before?

---

components/script/script_thread.rs, line 1302 [r1] (raw file):

    /// Kick off the document and frame tree creation process using the result.
    fn handle_page_headers_available(&self, id: &PipelineId, subpage: Option<&SubpageId>,
                                  metadata: Option<Metadata>) -> Option<ParserRoot> {

ditto

---

components/script/dom/servohtmlparser.rs, line 98 [r2] (raw file):

        let content_type = metadata.clone().and_then(|meta| meta.content_type);
        let parser = match ScriptThread::page_headers_available(&self.id,
                                                             self.subpage.as_ref(),

here too, please :)

---

Comments from Reviewable

[emilio]

Also, if you could squash the commits, that would be great, let us know if you need any help with that :)

[rafaqtro]

yes, @emilio how do i squash the commits?

[jdm]

https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ is a useful reference.

[highfive]

New code was committed to pull request.

[KiChjang]

@bors-servo r=emilio

[bors-servo]

📌 Commit 71104c8 has been approved by emilio

[emilio]

Great, thanks for doing this @rafaqtro! :)

@bors-servo: r+

Take a look to https://starters.servo.org if you want to find another issue, we're happy to help!

[bors-servo]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: #11522

[bors-servo]

📌 Commit 71104c8 has been approved by emilio

[bors-servo]

⌛ Testing commit 71104c8 with merge 5d86b9b...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

[rafaqtro]

yes i would like to find other issue. if you can help me @emilio ?

[emilio]

Hi @rafaqtro,

So, would you like something like #11557, or maybe something a bit more challenging? If you'd prefer to use other languages, like JavaScript or Rust, there are also good first PRs for those, what would you be more interested in?

[rafaqtro]

yes, i do this, and after that, i could do some more challenging maybe in js.