Add test for float kerning, make disabled

[mitchhentges]

Make automated test for #11482

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes add a test for #11482

• There are tests for these changes

---

This change is

[mitchhentges]

There's a .items.reftest section and a .reftest_nodes section in MANIFEST.json. I'm not sure the pattern for where the test definition should go, so I put it in .items.reftest, and it's properly picked up by ./mach test-wpt, so I think it's happy

[mitchhentges]

Yep, it needed to be added to both sections, now CI doesn't fail

[highfive]

New code was committed to pull request.

[mitchhentges]

Am I not allowed to change the manifest?

$ bash etc/ci/manifest_changed.sh
diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json
index c617a0f..42570f8 100644
--- a/tests/wpt/mozilla/meta/MANIFEST.json
+++ b/tests/wpt/mozilla/meta/MANIFEST.json
@@ -8516,6 +8516,18 @@
           "url": "/_mozilla/css/float_intrinsic_width_a.html"
         }
       ],
+      "css/float_kerning_a.html": [
+        {
+          "path": "css/float_kerning_a.html",
+          "references": [
+            [
+              "/_mozilla/css/float_kerning_ref.html",
+              "=="
+            ]
+          ],
+          "url": "/_mozilla/css/float_kerning_a.html"
+        }
+      ],
       "css/float_overflow_area_a.html": [
         {
           "path": "css/float_overflow_area_a.html",
The command "bash etc/ci/manifest_changed.sh" exited with 1.

[KiChjang]

Have you tried using ./mach create-wpt to create tests?

[highfive]

New code was committed to pull request.

[mitchhentges]

I re-did this according to ./mach create-wpt, but MANIFEST.json is still changed. However, now two places in the manifest have been updated. Maybe it will be happy now?

[KiChjang]

Yep, Travis CI doesn't complain now.

@bors-servo try

[bors-servo]

⌛ Trying commit 40ab16d with merge 8de46f3...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

[Ms2ger]

I'm not sure I see the point of this PR: you're adding a test, but not running it? Did you mean to mark it as failing instead?

[mitchhentges]

Ah, yes, I want to add it as failing. Still figuring out how the wpt test configuration happens :)

[Ms2ger]

See https://github.com/servo/servo/blob/e8e7c65/tests/wpt/metadata/html/rendering/non-replaced-elements/lists/li-type-supported.html.ini for an example

[highfive]

New code was committed to pull request.

[Ms2ger]

Looks good in terms of metadata; r? @mbrubeck for the test

[mbrubeck]

Something is wrong; this test is not passing in Gecko or Blink. In both cases the horizontal position of the .float element in the test case is different than the position of the .fixed element in the reference. In Gecko the green/red/orange backgrounds are also showing; I think adding an explicit line-height: 1; fixes this.

I'm also not sure it will be possible to reproduce this bug using Ahem, because I don't think it has any kerning tables. :( This may depend on something like #8374 so we can use a known font other than Ahem.

[mitchhentges]

Ah, yes, I think I got dinged by ./mach run not using Ahem and falling back to some other font, and for some reason I thought that the other font was Ahem. Oops for the confusion, I'll wait until more cross-platform servo fonts exist that are available in both ./mach run and ./mach test