Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting all URIs to URLs #11532

Closed
wants to merge 1 commit into from
Closed

Converting all URIs to URLs #11532

wants to merge 1 commit into from

Conversation

@Coder206
Copy link
Contributor

Coder206 commented Jun 1, 2016

This addresses the fix for #11450


This change is Reviewable

@highfive
Copy link

highfive commented Jun 1, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive
Copy link

highfive commented Jun 1, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/BrowserElement.webidl, components/script/dom/htmliframeelement.rs
@highfive
Copy link

highfive commented Jun 1, 2016

warning Warning warning

  • This pull request modifies the contents of
    tests/wpt/css-tests/, which are overwriten occasionally whenever the
    directory is synced from upstream.
@KiChjang
Copy link
Member

KiChjang commented Jun 1, 2016

This contains fixes to the tests/ directory as well, which I think is not intended.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang Is it possible to select certain files for the PR merge?

@KiChjang
Copy link
Member

KiChjang commented Jun 1, 2016

No, but it's possible to revert your changes on the tests/ files.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang I am just starting out, do you know the steps to doing this?

@KiChjang
Copy link
Member

KiChjang commented Jun 1, 2016

git checkout HEAD^ -- tests and then git commit --amend -C HEAD should do the trick. You'll need to force-push your changes after by doing git push -f.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang Thanks for all your help! I appreciate it! :)

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang I made the changes.

@KiChjang
Copy link
Member

KiChjang commented Jun 1, 2016

It doesn't seem like you've pushed anything to your branch; we can't see your changes.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang Hang on, I just forgot the last code snippet.

This addresses the fix for #11450
@highfive
Copy link

highfive commented Jun 1, 2016

New code was committed to pull request.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang There we go!

@KiChjang
Copy link
Member

KiChjang commented Jun 1, 2016

I'm still seeing changes in the tests/ directory.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 1, 2016

@KiChjang That's odd. I think I am going to pull down my PR request and rework this fix.

@Coder206 Coder206 closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.