Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some build warnings. #11538

Merged
merged 1 commit into from Jun 1, 2016
Merged

Fix some build warnings. #11538

merged 1 commit into from Jun 1, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 1, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because refactoring

This change is Reviewable
@Ms2ger
Fix some build warnings.
Loading status checks…
46ea78e
@highfive
Copy link

highfive commented Jun 1, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/worker.rs, components/script/script_thread.rs, components/script/dom/dedicatedworkerglobalscope.rs
@highfive
Copy link

highfive commented Jun 1, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Jun 1, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2016

📌 Commit 46ea78e has been approved by emilio
@highfive highfive assigned emilio and unassigned glennw Jun 1, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2016

⌛ Testing commit 46ea78e with merge 0594d58...
bors-servo added a commit that referenced this pull request Jun 1, 2016
@bors-servo
Auto merge of #11538 - Ms2ger:warnings, r=emilio
Loading status checks…
0594d58 
Fix some build warnings.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because refactoring

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 46ea78e into servo:master Jun 1, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jun 1, 2016
Merged
Merged
@Ms2ger Ms2ger deleted the Ms2ger:warnings branch Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @emilio @bors-servo @glennw
You can’t perform that action at this time.