Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustc to 2016-06-02. #11558

Closed
wants to merge 1 commit into from
Closed

Update rustc to 2016-06-02. #11558

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 2, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Update rustc to 2016-06-02.
Loading status checks…
24e60c7
@highfive
Copy link

highfive commented Jun 2, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Jun 2, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@metajack
Copy link
Contributor

metajack commented Jun 2, 2016

@bors-servo r+

Previously, highfive wrote…

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2016

📌 Commit 24e60c7 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2016

⌛ Testing commit 24e60c7 with merge 9084cda...
bors-servo added a commit that referenced this pull request Jun 2, 2016
@bors-servo
Auto merge of #11558 - servo:rustup, r=metajack
9084cda 
Update rustc to 2016-06-02.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11558)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 2, 2016

💔 Test failed - arm32
@nox
Copy link
Member

nox commented Jun 2, 2016

This doesn't bump all the Serde dependencies, and I think that's a bad thing.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

☔ The latest upstream changes (presumably #11591) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox closed this Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @metajack @bors-servo @nox
You can’t perform that action at this time.