Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Clone for DOMManipulationTaskSource, UserInteractionTaskSource. #11571

Merged
merged 1 commit into from Jun 3, 2016
Merged

Derive Clone for DOMManipulationTaskSource, UserInteractionTaskSource. #11571

merged 1 commit into from Jun 3, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Derive Clone for DOMManipulationTaskSource, UserInteractionTaskSource.
Loading status checks…
0861b70
@highfive
Copy link

highfive commented Jun 3, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/task_source/user_interaction.rs, components/script/task_source/dom_manipulation.rs
@highfive
Copy link

highfive commented Jun 3, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Jun 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

📌 Commit 0861b70 has been approved by nox
@highfive highfive assigned nox and unassigned mbrubeck Jun 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

⌛ Testing commit 0861b70 with merge b8414f6...
bors-servo added a commit that referenced this pull request Jun 3, 2016
@bors-servo
Auto merge of #11571 - Ms2ger:derive-clone, r=nox
b8414f6 
Derive Clone for DOMManipulationTaskSource, UserInteractionTaskSource.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11571)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 3, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 3, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

⌛ Testing commit 0861b70 with merge e75339c...
bors-servo added a commit that referenced this pull request Jun 3, 2016
@bors-servo
Auto merge of #11571 - Ms2ger:derive-clone, r=nox
Loading status checks…
e75339c 
Derive Clone for DOMManipulationTaskSource, UserInteractionTaskSource.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11571)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 3, 2016 

  ▶ FAIL [expected PASS] /cs</span><span class="stdout">s-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 3, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 0861b70 into servo:master Jun 3, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:derive-clone branch Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @mbrubeck
You can’t perform that action at this time.