Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Document interface #11586

Merged
merged 1 commit into from Jun 4, 2016
Merged

Cleanup Document interface #11586

merged 1 commit into from Jun 4, 2016

Conversation

@nox
Copy link
Member

nox commented Jun 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Jun 3, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/Document.webidl
@highfive
Copy link

highfive commented Jun 3, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jun 3, 2016

@bors-servo rollup
@nox nox force-pushed the nox:document branch from 00ada93 to 32a9801 Jun 3, 2016
@highfive
Copy link

highfive commented Jun 3, 2016

New code was committed to pull request.
@nox
Cleanup Document interface
Loading status checks…
99c720f
@nox nox force-pushed the nox:document branch from 32a9801 to 99c720f Jun 3, 2016
@highfive
Copy link

highfive commented Jun 3, 2016

New code was committed to pull request.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

📌 Commit 99c720f has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned jdm Jun 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 99c720f with merge 07c1462...
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11586 - nox:document, r=Ms2ger
07c1462 
Cleanup Document interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11586)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@nox
Copy link
Member Author

nox commented Jun 4, 2016

@bors-servo retry #11561
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 99c720f with merge c2fad1f...
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11586 - nox:document, r=Ms2ger
c2fad1f 
Cleanup Document interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11586)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@nox
Copy link
Member Author

nox commented Jun 4, 2016

@bors-servo retry #11574
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jun 4, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@nox
Copy link
Member Author

nox commented Jun 4, 2016

@bors-servo retry #11561
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jun 4, 2016
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11586 - nox:document, r=Ms2ger
Loading status checks…
a5115c1 
Cleanup Document interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11586)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 99c720f with merge a5115c1...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 99c720f into servo:master Jun 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 4, 2016
Merged
@nox nox deleted the nox:document branch Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @Ms2ger @bors-servo @jdm
You can’t perform that action at this time.