Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Element interface #11587

Merged
merged 1 commit into from Jun 6, 2016
Merged

Cleanup Element interface #11587

merged 1 commit into from Jun 6, 2016

Conversation

@nox
Copy link
Member

nox commented Jun 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@nox
Cleanup Element interface
Loading status checks…
72dae53
@highfive
Copy link

highfive commented Jun 3, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/Element.webidl
@highfive
Copy link

highfive commented Jun 3, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jun 3, 2016

@bors-servo rollup
@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2016

📌 Commit 72dae53 has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned KiChjang Jun 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 72dae53 with merge 273d672...
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11587 - nox:element, r=Ms2ger
273d672 
Cleanup Element interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Jun 4, 2016

@bors-servo retry

  • The annoying git
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11587 - nox:element, r=Ms2ger
9aadbb2 
Cleanup Element interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 72dae53 with merge 9aadbb2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member Author

nox commented Jun 4, 2016

@bors-servo retry #JustGitThings
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit 72dae53 with merge 4804ff1...
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11587 - nox:element, r=Ms2ger
4804ff1 
Cleanup Element interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/textures/default-texture.html:
  │ FAIL [expected PASS] WebGL test #0: at (0, 0) expected: 0,0,0,255 was 255,255,255,255
  │   → assert_true: at (0, 0) expected: 0,0,0,255 was 255,255,255,255 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ checkCanvas@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1095:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/textures/default-texture.html:14:1

  ▶ TIMEOUT [expected OK] /websockets/closing-handshake/002.html

  ▶ TIMEOUT [expected OK] /websockets/closing-handshake/002.html?wss

  ▶ TIMEOUT [expected OK] /websockets/closing-handshake/003.html
@nox
Copy link
Member Author

nox commented Jun 6, 2016

@bors-servo retry #11618
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jun 6, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2016

⌛ Testing commit 72dae53 with merge 2083a8c...
bors-servo added a commit that referenced this pull request Jun 6, 2016
@bors-servo
Auto merge of #11587 - nox:element, r=Ms2ger
Loading status checks…
2083a8c 
Cleanup Element interface

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 72dae53 into servo:master Jun 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @Ms2ger @bors-servo @KiChjang
You can’t perform that action at this time.