Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate mozbrowserlocationchange_event.html #11603
Conversation
highfive
commented
Jun 4, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
@asajeffrey Here is the long overdue and awaited code for your issue post (#11450). I noticed there were a few URIs left in the iframe related Rust files, should I change these too? The files are: I made a test change on a Fedora 23 VM for the file changes, there were no errors if these were corrected as well. Do you want these modified as well? Please note, they will be outputted when exclusively changing the URI to URL for https://github.com/servo/servo/blob/master/components/script/dom/webidls/BrowserElement.webidl#L66 |
|
r? @asajeffrey |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
I think some of the files are missing, this PR just has changes to Glad that you were able to submit! |
|
@asajeffrey I thought it was working. I am having lots of trouble getting Servo and BrowserHTML working. |
|
@asajeffrey Can I add to this PR the changes? |
|
@Coder206 yes, just push new commits. |
|
Please consult #11765 |
|
#11782 is the new PR for this |
Coder206 commentedJun 4, 2016
•
edited by KiChjang
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is