Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mozbrowserlocationchange_event.html #11603

Closed
wants to merge 1 commit into from

Conversation

@Coder206
Copy link
Contributor

Coder206 commented Jun 4, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11450 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because @asajeffrey just wanted compiled code (testing was and still isn't working for me on Windows 10)

This change is Reviewable

@highfive
Copy link

highfive commented Jun 4, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 4, 2016

@asajeffrey Here is the long overdue and awaited code for your issue post (#11450). I noticed there were a few URIs left in the iframe related Rust files, should I change these too?

The files are:
servo/tests/wpt/mozilla/tests/mozilla/mozbrowser/iframe_goback.html (line 23 and 24)
servo/tests/wpt/mozilla/tests/mozilla/mozbrowser/redirect.html (line 13)

I made a test change on a Fedora 23 VM for the file changes, there were no errors if these were corrected as well. Do you want these modified as well?

Please note, they will be outputted when exclusively changing the URI to URL for https://github.com/servo/servo/blob/master/components/script/dom/webidls/BrowserElement.webidl#L66

@KiChjang
Copy link
Member

KiChjang commented Jun 4, 2016

@highfive highfive assigned asajeffrey and unassigned pcwalton Jun 4, 2016
@asajeffrey
Copy link
Member

asajeffrey commented Jun 4, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@asajeffrey
Copy link
Member

asajeffrey commented Jun 4, 2016

I think some of the files are missing, this PR just has changes to tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowserlocationchange_event.html.

Glad that you were able to submit!

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 4, 2016

@asajeffrey I thought it was working. I am having lots of trouble getting Servo and BrowserHTML working.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 4, 2016

@asajeffrey Can I add to this PR the changes?

@asajeffrey
Copy link
Member

asajeffrey commented Jun 4, 2016

@Coder206 yes, just push new commits.

@Coder206
Copy link
Contributor Author

Coder206 commented Jun 17, 2016

Please consult #11765

@Coder206 Coder206 closed this Jun 17, 2016
@Coder206
Copy link
Contributor Author

Coder206 commented Jun 18, 2016

#11782 is the new PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.