Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to DOMSettableTokenList #11606

Merged
merged 1 commit into from Jun 5, 2016
Merged

Removed references to DOMSettableTokenList #11606

merged 1 commit into from Jun 5, 2016

Conversation

@kevgs
Copy link
Contributor

kevgs commented Jun 4, 2016 •
edited by larsbergstrom

PR to #11578

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Jun 4, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/HTMLTableCellElement.webidl, components/script/dom/webidls/HTMLIFrameElement.webidl, components/script/dom/webidls/HTMLAnchorElement.webidl, components/script/dom/webidls/HTMLLinkElement.webidl, components/script/dom/webidls/HTMLAreaElement.webidl, components/script/dom/webidls/HTMLOutputElement.webidl
@nox
Copy link
Member

nox commented Jun 4, 2016

-S-awaiting-review +S-needs-code-changes

Thanks for your contribution!

Previously, highfive wrote…

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/HTMLTableCellElement.webidl, components/script/dom/webidls/HTMLIFrameElement.webidl, components/script/dom/webidls/HTMLAnchorElement.webidl, components/script/dom/webidls/HTMLLinkElement.webidl, components/script/dom/webidls/HTMLAreaElement.webidl, components/script/dom/webidls/HTMLOutputElement.webidl

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

a discussion (no related file):
The two tests of which you modified the expectations should be changed accordingly too.

  • tests/wpt/web-platform-tests/dom/interface-objects.html
  • tests/wpt/web-platform-tests/dom/interfaces.html

components/script/dom/webidls/HTMLAnchorElement.webidl, line 17 [r1] (raw file):

  attribute DOMString target;
  //         attribute DOMString download;
  //[PutForwards=value] attribute DOMSettableTokenList ping;

This should become:

attribute USVString ping;

components/script/dom/webidls/HTMLAreaElement.webidl, line 12 [r1] (raw file):

  //         attribute DOMString target;
  //         attribute DOMString download;
  //[PutForwards=value] attribute DOMSettableTokenList ping;

This should become:

attribute USVString ping;

components/script/dom/webidls/HTMLElement.webidl, line 32 [r1] (raw file):

  //readonly attribute DOMString accessKeyLabel;
  //         attribute boolean draggable;
  //[PutForwards=value] readonly attribute DOMSettableTokenList dropzone;

This should become:

[SameObject, PutForwards=value] readonly attribute DOMTokenList dropzone;

components/script/dom/webidls/HTMLLinkElement.webidl, line 14 [r1] (raw file):

           attribute DOMString hreflang;
           attribute DOMString type;
  //[PutForwards=value] readonly attribute DOMSettableTokenList sizes;

This should become:

[SameObject, PutForwards=value] readonly attribute DOMTokenList sizes;

components/script/dom/webidls/HTMLOutputElement.webidl, line 7 [r1] (raw file):

// https://html.spec.whatwg.org/multipage/#htmloutputelement
interface HTMLOutputElement : HTMLElement {
  //[PutForwards=value] readonly attribute DOMSettableTokenList htmlFor;

This should become:

[SameObject, PutForwards=value] readonly attribute DOMTokenList htmlFor;

components/script/dom/webidls/HTMLTableCellElement.webidl, line 10 [r1] (raw file):

             attribute unsigned long colSpan;
  //         attribute unsigned long rowSpan;
  //[PutForwards=value] readonly attribute DOMSettableTokenList headers;

This should become:

attribute DOMString headers;

tests/wpt/web-platform-tests/dom/historical.html, line 21 [r1] (raw file):

  "DOMLocator",
  "DOMObject",
  "DOMSettableTokenList",

This should be restored, that's the list of nuked interfaces, and DOMSettableTokenList indeed got nuked.

Comments from Reviewable
@nox nox assigned nox and unassigned asajeffrey Jun 4, 2016
@kevgs
Copy link
Contributor Author

kevgs commented Jun 4, 2016

I need to implement setters and getters for a new fields, right?
@nox
Copy link
Member

nox commented Jun 4, 2016

@kevgs kevgs force-pushed the kevgs:dom_settable_token_list branch from 167ce5d to 76d679a Jun 4, 2016
@highfive
Copy link

highfive commented Jun 4, 2016

New code was committed to pull request.
@kevgs kevgs force-pushed the kevgs:dom_settable_token_list branch from 76d679a to a4a50a5 Jun 4, 2016
@highfive
Copy link

highfive commented Jun 4, 2016

New code was committed to pull request.
@nox
Copy link
Member

nox commented Jun 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

📌 Commit a4a50a5 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

⌛ Testing commit a4a50a5 with merge 8605c14...
bors-servo added a commit that referenced this pull request Jun 4, 2016
@bors-servo
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
8605c14 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ CRASH [expected OK] /dom/nodes/Node-parentNode.html
  │ 
  │ ERROR:constellation::constellation: Panic: resize sent to nonexistent pipeline
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x00000001064db67e - backtrace::backtrace::trace::hde0eaf64954d96a0
  │ frame #1  - 0x00000001064db601 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x0000000105a1c836 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hcc1d865e247a370a
  │ frame #3  - 0x00000001064c100a - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x00000001066cdfe2 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │ frame #5  - 0x00000001053de434 - std::panicking::begin_panic::h4ebf9fe884b2415f
  │ frame #6  - 0x0000000105a7c0c0 - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h41a556e2c2c94fe6
  │ frame #7  - 0x0000000105a5eb22 - script::script_thread::ScriptThread::handle_msgs::h6a699373a020da16
  │ frame #8  - 0x0000000105a1afe7 - std::panicking::try::call::hc9179c9e89d6d659
  │ frame #9  - 0x00000001066e965b - __rust_try
  │ frame #10 - 0x00000001066e95f5 - __rust_maybe_catch_panic
  │ frame #11 - 0x0000000105a1c264 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hbef70c0af4cb429b
  │ frame #12 - 0x00000001066e5318 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │ frame #13 - 0x00007fff9534f059 - _pthread_body
  │ frame #14 - 0x00007fff9534efd6 - _pthread_start
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!
@kevgs
Copy link
Contributor Author

kevgs commented Jun 4, 2016

If this crash related to OSX I barely can fix it because I have only Ubuntu.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

☔ The latest upstream changes (presumably #11615) made this pull request unmergeable. Please resolve the merge conflicts.
@kevgs
Removed references to DOMSettableTokenList
Loading status checks…
a121437
@nox nox removed the S-tests-failed label Jun 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

⌛ Testing commit a121437 with merge d801d41...
bors-servo added a commit that referenced this pull request Jun 5, 2016
@bors-servo
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
d801d41 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member

nox commented Jun 5, 2016

@bors-servo retry #JustGitThings
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

⌛ Testing commit a121437 with merge 490087d...
bors-servo added a commit that referenced this pull request Jun 5, 2016
@bors-servo
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
490087d 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member

nox commented Jun 5, 2016

@bors-servo retry #JustGitThings
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jun 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

⌛ Testing commit a121437 with merge 44126da...
bors-servo added a commit that referenced this pull request Jun 5, 2016
@bors-servo
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
Loading status checks…
44126da 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member

nox commented Jun 5, 2016

@bors-servo retry #JustGitThings
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows are reusable. Rebuilding only android, linux-rel, mac-rel-css, mac-rel-wpt...
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jun 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit a121437 into servo:master Jun 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@timvandermeij timvandermeij mentioned this pull request Jun 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kevgs @highfive @nox @bors-servo @asajeffrey
You can’t perform that action at this time.