Fix all the links to the UI Events spec #11610

nox · 2016-06-04T14:01:56Z

This change is

highfive · 2016-06-04T14:01:59Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/document.rs, components/script/dom/webidls/MouseEvent.webidl, components/script/dom/keyboardevent.rs, components/script/dom/webidls/KeyboardEvent.webidl, components/script/script_thread.rs, components/script/dom/webidls/UIEvent.webidl, components/script/dom/uievent.rs

highfive · 2016-06-04T14:02:00Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

nox · 2016-06-04T14:02:02Z

@bors-servo rollup


        Fix all the links to the UI Events spec

DOM3Events is no more.

highfive · 2016-06-04T14:04:39Z

New code was committed to pull request.

emilio · 2016-06-04T14:06:00Z

@bors-servo: r+ rollup

bors-servo · 2016-06-04T14:06:01Z

📌 Commit be334ef has been approved by emilio

bors-servo · 2016-06-04T22:42:29Z

⌛ Testing commit be334ef with merge 452d505...


        Auto merge of #11610 - nox:dom3events, r=emilio

Fix all the links to the UI Events spec  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11610)

bors-servo · 2016-06-04T23:29:20Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-04T23:29:23Z

  ▶ Unexpected subtest result in /cssom-view/elementScroll.html:
  │ FAIL [expected PASS] Element scrollTop/Left getter/setter test
  │   → assert_equals: changed scrollTop should be 40 expected 30 but got 0
  │ 
  │ window.onload/&lt;@http://web-platform.test:8000/cssom-view/elementScroll.html:12:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ window.onload@http://web-platform.test:8000/cssom-view/elementScroll.html:5:9

  ▶ Unexpected subtest result in /cssom-view/elementScroll.html:
  │ FAIL [expected PASS] Element scrollTo test
  │   → assert_equals: changed scrollLeft should be 70 expected 80 but got 0
  │ 
  │ window.onload/&lt;@http://web-platform.test:8000/cssom-view/elementScroll.html:26:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ window.onload@http://web-platform.test:8000/cssom-view/elementScroll.html:23:9

  ▶ Unexpected subtest result in /cssom-view/elementScroll.html:
  │ FAIL [expected PASS] cssom-view - elementScroll
  │   → assert_equals: increment of scrollLeft should be 10 expected 10 but got 0
  │ 
  │ window.onload/&lt;@http://web-platform.test:8000/cssom-view/elementScroll.html:36:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ window.onload@http://web-platform.test:8000/cssom-view/elementScroll.html:30:9

  ▶ Unexpected subtest result in /cssom-view/elementScroll.html:
  │ FAIL [expected PASS] Element scroll test
  │   → assert_equals: changed scrollLeft should be 60 expected 50 but got 0
  │ 
  │ window.onload/&lt;@http://web-platform.test:8000/cssom-view/elementScroll.html:19:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ window.onload@http://web-platform.test:8000/cssom-view/elementScroll.html:16:9

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/textures/default-texture.html:
  │ FAIL [expected PASS] WebGL test #0: at (0, 0) expected: 0,0,0,255 was 255,255,255,255
  │   → assert_true: at (0, 0) expected: 0,0,0,255 was 255,255,255,255 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ checkCanvas@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1095:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/textures/default-texture.html:14:1

cbrewster · 2016-06-04T23:34:46Z

@bors-servo retry

bors-servo · 2016-06-05T00:17:16Z

⌛ Testing commit be334ef with merge 0a139ef...


        Auto merge of #11610 - nox:dom3events, r=emilio

Fix all the links to the UI Events spec  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11610)

bors-servo · 2016-06-05T00:37:25Z

💔 Test failed - mac-rel-css

cbrewster · 2016-06-05T00:41:00Z

@bors-servo retry

git

bors-servo · 2016-06-05T01:25:36Z

⌛ Testing commit be334ef with merge 573c0a7...


        Auto merge of #11610 - nox:dom3events, r=emilio

Fix all the links to the UI Events spec  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11610)

bors-servo · 2016-06-05T02:11:26Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-05T02:11:28Z

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/textures/default-texture.html:
  │ FAIL [expected PASS] WebGL test #0: at (0, 0) expected: 0,0,0,255 was 255,255,255,255
  │   → assert_true: at (0, 0) expected: 0,0,0,255 was 255,255,255,255 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ checkCanvas@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1095:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/textures/default-texture.html:14:1

cbrewster · 2016-06-05T02:27:40Z

@bors-servo retry

#11618

bors-servo · 2016-06-05T02:27:42Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-06-05T03:13:17Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned emilio Jun 4, 2016

highfive added the S-awaiting-review label Jun 4, 2016

Fix all the links to the UI Events spec

Loading status checks…

be334ef

DOM3Events is no more.

nox force-pushed the nox:dom3events branch from 5342ce7 to be334ef Jun 4, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 4, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 4, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 5, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 5, 2016

highfive removed the S-tests-failed label Jun 5, 2016

highfive added the S-awaiting-merge label Jun 5, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 5, 2016

bors-servo merged commit be334ef into servo:master Jun 5, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

servo / servo

Fix all the links to the UI Events spec #11610

Fix all the links to the UI Events spec #11610

nox commented Jun 4, 2016 •

edited by larsbergstrom

highfive commented Jun 4, 2016

highfive commented Jun 4, 2016

nox commented Jun 4, 2016

highfive commented Jun 4, 2016

emilio commented Jun 4, 2016

bors-servo commented Jun 4, 2016

bors-servo commented Jun 4, 2016

bors-servo commented Jun 4, 2016

highfive commented Jun 4, 2016

cbrewster commented Jun 4, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

cbrewster commented Jun 5, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

highfive commented Jun 5, 2016

cbrewster commented Jun 5, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

servo / servo

Join GitHub today

Fix all the links to the UI Events spec #11610

Fix all the links to the UI Events spec #11610

Conversation

nox commented Jun 4, 2016 • edited by larsbergstrom

highfive commented Jun 4, 2016

highfive commented Jun 4, 2016

nox commented Jun 4, 2016

highfive commented Jun 4, 2016

emilio commented Jun 4, 2016

bors-servo commented Jun 4, 2016

bors-servo commented Jun 4, 2016

bors-servo commented Jun 4, 2016

highfive commented Jun 4, 2016

cbrewster commented Jun 4, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

cbrewster commented Jun 5, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

highfive commented Jun 5, 2016

cbrewster commented Jun 5, 2016

bors-servo commented Jun 5, 2016

bors-servo commented Jun 5, 2016

nox commented Jun 4, 2016 •

edited by larsbergstrom