Implement [Unscopable] (fixes #11583)

[nox]

This change is

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/interface.rs, components/script/dom/webidls/ChildNode.webidl, components/script/dom/webidls/ParentNode.webidl

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[nox]

r? @Ms2ger

[nox]

@bors-servo try

[bors-servo]

⌛ Trying commit 64c1e00 with merge 36360b9...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

[Ms2ger]

-S-awaiting-review +S-needs-code-changes

Previously, bors-servo wrote…

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

---

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

components/script/dom/bindings/interface.rs, line 249 [r1] (raw file):

        let unscopable_symbol = GetWellKnownSymbol(cx, SymbolCode::unscopables);
        assert!(!unscopable_symbol.is_null());
        let unscopable_id = RootedId::new(cx, RUST_SYMBOL_TO_JSID(unscopable_symbol));

Please try to add a few empty lines in this block

---

components/script/dom/bindings/codegen/CodegenRust.py, line 5121 [r1] (raw file):

        haveUnscopables = (len(unscopableNames) != 0 and
                           descriptor.interface.hasInterfacePrototypeObject())

Please don't use hasInterfacePrototypeObject; make this if unscopableNames: under the if not descriptor.interface.isCallback(): block.

---

components/script/dom/webidls/ChildNode.webidl, line 11 [r1] (raw file):

[NoInterfaceObject]
interface ChildNode {
  [Throws, Unscopable]

I'd like all of those to be tested. (idlharness?)

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[nox]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

components/script/dom/bindings/interface.rs, line 249 [r1] (raw file):

Previously, Ms2ger wrote…

Please try to add a few empty lines in this block

Done.

---

components/script/dom/bindings/codegen/CodegenRust.py, line 5121 [r1] (raw file):

Previously, Ms2ger wrote…

Please don't use hasInterfacePrototypeObject; make this if unscopableNames: under the if not descriptor.interface.isCallback(): block.

Done.

---

components/script/dom/webidls/ChildNode.webidl, line 11 [r1] (raw file):

Previously, Ms2ger wrote…

I'd like all of those to be tested. (idlharness?)

Done.

---

Comments from Reviewable

[Ms2ger]

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

tests/wpt/web-platform-tests/dom/nodes/remove-unscopable.html, line 18 [r2] (raw file):

    "append"
];
for (i in unscopables) {

var i

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[Ms2ger]

@bors-servo r+

Previously, highfive wrote…

New code was committed to pull request.

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[bors-servo]

📌 Commit 3529803 has been approved by Ms2ger

[bors-servo]

⌛ Testing commit 3529803 with merge f56848a...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows