Reduce the amount of dom code used outside the script crate. #11656

Ms2ger · 2016-06-07T12:22:56Z

This change is


        Move the definition of ServoThreadSafeLayoutNode::selection to script.


        Move the definition of ServoThreadSafeLayoutNode::image_url to script.


        Move the definition of ServoThreadSafeLayoutNode::canvas_data to script.


        Move the definition of ServoThreadSafeLayoutNode::iframe_pipeline_id …

…to script.


        Stop re-exporting AttrValue.


        Make layout only depend on script::layout_interface.


        Move trim_http_whitespace to net_traits.


        Remove unused ByteString::bytes() and its unit test.

highfive · 2016-06-07T12:22:58Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/htmlappletelement.rs, components/script/dom/htmlmetaelement.rs, components/script/layout_interface.rs, components/script/dom/htmlselectelement.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/htmltablesectionelement.rs, components/script/dom/element.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/htmltablerowelement.rs, components/script/dom/virtualmethods.rs, components/script/dom/htmltablecellelement.rs, components/script/dom/htmlfontelement.rs, components/script/dom/htmllabelelement.rs, components/script/dom/htmltextareaelement.rs, components/script/dom/htmlbaseelement.rs, components/script/dom/macros.rs, components/script/dom/htmltableelement.rs, components/script/dom/htmlimageelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/bindings/str.rs, components/script/dom/htmlbodyelement.rs, components/script/dom/htmliframeelement.rs, components/script/dom/htmlareaelement.rs, components/script/dom/attr.rs, components/script/dom/node.rs, components/script/dom/htmlelement.rs, components/script/dom/htmlanchorelement.rs, components/script/dom/htmlformelement.rs, components/script/dom/htmlhrelement.rs

highfive · 2016-06-07T12:22:59Z

Warning

These commits modify unsafe code. Please review it carefully!

nox · 2016-06-07T12:33:55Z

@bors-servo r+

Previously, highfive wrote…

Warning

These commits modify unsafe code. Please review it carefully!

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, 28 of 28 files at r5, 6 of 6 files at r6, 5 of 5 files at r7, 3 of 3 files at r8.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

bors-servo · 2016-06-07T12:33:56Z

📌 Commit aea03b2 has been approved by nox

jdm · 2016-06-07T12:38:47Z

Should we add a test-tidy check to prevent any non layout_interface script dependencies being added to layout?

bors-servo · 2016-06-07T13:11:28Z

⌛ Testing commit aea03b2 with merge 74045fd...


        Auto merge of #11656 - Ms2ger:reduce-dom-exposure, r=nox

Reduce the amount of dom code used outside the script crate.  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11656)

bors-servo · 2016-06-07T14:04:14Z

💔 Test failed - linux-rel

highfive · 2016-06-07T14:04:17Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8

Ms2ger · 2016-06-07T14:06:19Z

@bors-servo retry #11561

bors-servo · 2016-06-07T16:09:15Z

⌛ Testing commit aea03b2 with merge 1e3edf3...


        Auto merge of #11656 - Ms2ger:reduce-dom-exposure, r=nox

Reduce the amount of dom code used outside the script crate.  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11656)

bors-servo · 2016-06-07T16:44:37Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-07T16:44:39Z

  ▶ CRASH [expected OK] /dom/nodes/Node-parentNode.html
  │ 
  │ ERROR:constellation::constellation: Panic: resize sent to nonexistent pipeline
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x000000011086751e - backtrace::backtrace::trace::hde0eaf64954d96a0
  │ frame #1  - 0x00000001108674a1 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x000000010fda6506 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hcc1d865e247a370a
  │ frame #3  - 0x000000011084ceea - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x0000000110a59fa2 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │ frame #5  - 0x000000010f766304 - std::panicking::begin_panic::h4ebf9fe884b2415f
  │ frame #6  - 0x000000010fe05a00 - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h41a556e2c2c94fe6
  │ frame #7  - 0x000000010fde8462 - script::script_thread::ScriptThread::handle_msgs::h6a699373a020da16
  │ frame #8  - 0x000000010fda4cb7 - std::panicking::try::call::hc9179c9e89d6d659
  │ frame #9  - 0x0000000110a7561b - __rust_try
  │ frame #10 - 0x0000000110a755b5 - __rust_maybe_catch_panic
  │ frame #11 - 0x000000010fda5f34 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hbef70c0af4cb429b
  │ frame #12 - 0x0000000110a712d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │ frame #13 - 0x00007fff8e158059 - _pthread_body
  │ frame #14 - 0x00007fff8e157fd6 - _pthread_start
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!

KiChjang · 2016-06-07T17:04:30Z

@bors-servo retry

#11613

bors-servo · 2016-06-07T17:04:32Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-06-07T17:44:30Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

Ms2ger added 8 commits Jun 7, 2016

Move the definition of ServoThreadSafeLayoutNode::selection to script.

093b7b7

Move the definition of ServoThreadSafeLayoutNode::image_url to script.

ef3c6a7

Move the definition of ServoThreadSafeLayoutNode::canvas_data to script.

5859109

Move the definition of ServoThreadSafeLayoutNode::iframe_pipeline_id …

858ea2e

…to script.

Stop re-exporting AttrValue.

684510b

Make layout only depend on script::layout_interface.

6a1722e

Move trim_http_whitespace to net_traits.

80fc666

Remove unused ByteString::bytes() and its unit test.

Loading status checks…

aea03b2

highfive assigned metajack Jun 7, 2016

highfive added the S-awaiting-review label Jun 7, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 7, 2016

highfive assigned nox and unassigned metajack Jun 7, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 7, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 7, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 7, 2016

bors-servo merged commit aea03b2 into servo:master Jun 7, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bors-servo mentioned this pull request Jun 7, 2016

Make fetch happen #11556

Merged

2 of 4 tasks complete

Ms2ger deleted the Ms2ger:reduce-dom-exposure branch Jun 16, 2016

servo / servo

Reduce the amount of dom code used outside the script crate. #11656

Reduce the amount of dom code used outside the script crate. #11656

Ms2ger commented Jun 7, 2016 •

edited by larsbergstrom

highfive commented Jun 7, 2016

highfive commented Jun 7, 2016

nox commented Jun 7, 2016

bors-servo commented Jun 7, 2016

jdm commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

highfive commented Jun 7, 2016

Ms2ger commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

highfive commented Jun 7, 2016

KiChjang commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

servo / servo

Join GitHub today

Reduce the amount of dom code used outside the script crate. #11656

Reduce the amount of dom code used outside the script crate. #11656

Conversation

Ms2ger commented Jun 7, 2016 • edited by larsbergstrom

highfive commented Jun 7, 2016

highfive commented Jun 7, 2016

nox commented Jun 7, 2016

bors-servo commented Jun 7, 2016

jdm commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

highfive commented Jun 7, 2016

Ms2ger commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

highfive commented Jun 7, 2016

KiChjang commented Jun 7, 2016

bors-servo commented Jun 7, 2016

bors-servo commented Jun 7, 2016

Ms2ger commented Jun 7, 2016 •

edited by larsbergstrom