Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly export an explicit public API in the style crate #1166
Conversation
bors-servo
pushed a commit
that referenced
this pull request
Nov 1, 2013
I.e. make every module private by default.
|
I forgot to submit servo/rust-cssparser#29 before this. |
|
This needs a rebase. |
This comment has been minimized.
This comment has been minimized.
|
r=pcwalton |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/private = 7a48cb6 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = bb71ee4 |
bors-servo
pushed a commit
that referenced
this pull request
Nov 1, 2013
I.e. make every module private by default.
bors-servo
merged commit 7a48cb6
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Test the metadata used for createHTMLDocument().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedNov 1, 2013
I.e. make every module private by default.