Added tests for cross-origin iframe parentage. #11666

asajeffrey · 2016-06-07T19:05:28Z

Added (currently failing) tests for cross-origin iframe parentage.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #11478
There are tests for these changes

This change is

highfive · 2016-06-09T14:10:18Z

New code was committed to pull request.

highfive · 2016-06-09T14:12:49Z

New code was committed to pull request.

asajeffrey · 2016-06-09T14:12:56Z

Rebased.

Manishearth · 2016-06-09T14:14:10Z

...atform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_grandchild.html

+</body>
+<script>
+    send_test_results({
+        "id": '6c8da65d-2c5e-44ef-bb0b-b8b9849aab19',


use token() or something

oh, not sure how token will work across iframes. @Ms2ger ?

Indeed, hence the hard-wired uuids.

asajeffrey · 2016-06-09T14:15:13Z

r? @ConnorGBrewster since you're already looking at #11677.

asajeffrey · 2016-06-09T14:16:08Z

Ah, crossed wires with @Manishearth.

bors-servo · 2016-06-09T19:29:56Z

☔ The latest upstream changes (presumably #11677) made this pull request unmergeable. Please resolve the merge conflicts.

asajeffrey · 2016-06-09T20:17:03Z

Rebased.

cbrewster · 2016-06-10T00:33:05Z

tests/wpt/metadata/MANIFEST.json

@@ -266,6 +266,10 @@
        "url": "/html-media-capture/capture_video_cancel-manual.html"
      },
      {
+        "path": "html/browsers/history/joint-session-history/joint-session-history-only-fully-active.html",


Should these lines be removed after moving the test?

Good catch, I think this comes from juggling several PRs at once, and having files leak from one branch to the other.

cbrewster · 2016-06-10T00:33:15Z

tests/wpt/metadata/MANIFEST.json

@@ -36026,7 +36030,9 @@
    ]
  },
  "local_changes": {
-    "deleted": [],
+    "deleted": [


Same as above

cbrewster · 2016-06-10T00:37:16Z

This looks good except possibly the changes on MANIFEST.json.

-S-awaiting-review +S-awaiting-answer

Previously, asajeffrey (Alan Jeffrey) wrote…

Rebased.

Reviewed 3 of 9 files at r1, 10 of 12 files at r2.
Review status: 4 of 5 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


        Added tests for cross-origin iframe parentage.

asajeffrey · 2016-06-10T13:58:02Z

Fixed MANIFEST.json. @bors-servo: r=ConnorGBrewster

bors-servo · 2016-06-10T13:58:04Z

📌 Commit 07ea9e6 has been approved by ConnorGBrewster

bors-servo · 2016-06-11T14:38:55Z

⌛ Testing commit 07ea9e6 with merge cd0cb71...


        Auto merge of #11666 - asajeffrey:cross-origin-parentage-test, r=Conn…

…orGBrewster Added tests for cross-origin iframe parentage.  Added (currently failing) tests for cross-origin iframe parentage. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11478 - [X] There are tests for these changes   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11666)

asajeffrey · 2016-06-11T15:03:59Z

Gosh this is a sad PR.

Manishearth · 2016-06-11T15:09:49Z

Fails /semantics/embedded-content/the-iframe-element/change_parentage.html on the waterfall it seems

http://build.servo.org/builders/linux-rel/builds/1601

bors-servo · 2016-06-11T15:21:13Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-11T15:21:17Z

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-contentType/contentType/contenttype_xml.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-contentType/contentType/createDocument.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-contentType/contentType/createHTMLDocument.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-contentType/contentType/xhr_responseType_document.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createAttribute.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createComment.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createElement.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createElementNS.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createEvent.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createProcessingInstruction-xhtml.xhtml

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createTextNode.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createProcessingInstruction.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-createTreeWalker.html

  ▶ TIMEOUT [expected OK] /dom/nodes/Document-doctype.html

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:
  │ FAIL [expected PASS] WebGL test #4: at (3, 16) expected: 0,0,0,0 was 0,0,224,207
  │   → assert_true: at (3, 16) expected: 0,0,0,0 was 0,0,224,207 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ testCanvasSizeChange@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:36:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:42:1

cbrewster · 2016-06-12T01:09:17Z

@bors-servo retry

#11721

bors-servo · 2016-06-12T02:08:03Z

⌛ Testing commit 07ea9e6 with merge 037ada6...


        Auto merge of #11666 - asajeffrey:cross-origin-parentage-test, r=Conn…

…orGBrewster Added tests for cross-origin iframe parentage.  Added (currently failing) tests for cross-origin iframe parentage. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11478 - [X] There are tests for these changes   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11666)

bors-servo · 2016-06-12T02:55:28Z

💔 Test failed - linux-rel

highfive · 2016-06-12T02:55:31Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728

cbrewster · 2016-06-12T14:36:34Z

@bors-servo retry


        Auto merge of #11666 - asajeffrey:cross-origin-parentage-test, r=Conn…

…orGBrewster Added tests for cross-origin iframe parentage.  Added (currently failing) tests for cross-origin iframe parentage. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11478 - [X] There are tests for these changes   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11666)

bors-servo · 2016-06-12T14:54:52Z

⌛ Testing commit 07ea9e6 with merge 0b2cc91...

bors-servo · 2016-06-12T15:15:00Z

💔 Test failed - mac-rel-css

cbrewster · 2016-06-12T15:22:40Z

@bors-servo retry

Infra (git)

bors-servo · 2016-06-12T16:02:47Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt, windows are reusable. Rebuilding only mac-rel-css...

bors-servo · 2016-06-12T16:43:20Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned Manishearth Jun 7, 2016

highfive added the S-awaiting-review label Jun 7, 2016

asajeffrey force-pushed the asajeffrey:cross-origin-parentage-test branch from f180d67 to 08dff69 Jun 9, 2016

asajeffrey force-pushed the asajeffrey:cross-origin-parentage-test branch from 08dff69 to 36f7663 Jun 9, 2016

Manishearth reviewed Jun 9, 2016
View changes

highfive assigned cbrewster and unassigned Manishearth Jun 9, 2016

highfive added the S-needs-rebase label Jun 9, 2016

asajeffrey force-pushed the asajeffrey:cross-origin-parentage-test branch from 36f7663 to 4477d80 Jun 9, 2016

cbrewster reviewed Jun 10, 2016
View changes

cbrewster added S-awaiting-answer and removed S-awaiting-review labels Jun 10, 2016

Added tests for cross-origin iframe parentage.

Loading status checks…

07ea9e6

asajeffrey force-pushed the asajeffrey:cross-origin-parentage-test branch from 4477d80 to 07ea9e6 Jun 10, 2016

highfive added the S-awaiting-review label Jun 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase S-awaiting-answer labels Jun 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 11, 2016

cbrewster mentioned this pull request Jun 12, 2016

Intermittent timeout of lots of websocket tests #11725

Closed

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 12, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 12, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 12, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 12, 2016

bors-servo merged commit 07ea9e6 into servo:master Jun 12, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

servo / servo

Added tests for cross-origin iframe parentage. #11666

Added tests for cross-origin iframe parentage. #11666

asajeffrey commented Jun 7, 2016 •

edited by larsbergstrom

highfive commented Jun 9, 2016

highfive commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

asajeffrey commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

bors-servo commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cbrewster commented Jun 10, 2016

asajeffrey commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 11, 2016

asajeffrey commented Jun 11, 2016

Manishearth commented Jun 11, 2016

bors-servo commented Jun 11, 2016

highfive commented Jun 11, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

highfive commented Jun 12, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

servo / servo

Join GitHub today

Added tests for cross-origin iframe parentage. #11666

Added tests for cross-origin iframe parentage. #11666

Conversation

asajeffrey commented Jun 7, 2016 • edited by larsbergstrom

highfive commented Jun 9, 2016

highfive commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

This comment has been minimized.

Manishearth Jun 9, 2016

This comment has been minimized.

Manishearth Jun 9, 2016

This comment has been minimized.

asajeffrey Jun 9, 2016

asajeffrey commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

bors-servo commented Jun 9, 2016

asajeffrey commented Jun 9, 2016

This comment has been minimized.

cbrewster Jun 10, 2016

This comment has been minimized.

asajeffrey Jun 10, 2016

This comment has been minimized.

cbrewster Jun 10, 2016

This comment has been minimized.

asajeffrey Jun 10, 2016

cbrewster commented Jun 10, 2016

asajeffrey commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 11, 2016

asajeffrey commented Jun 11, 2016

Manishearth commented Jun 11, 2016

bors-servo commented Jun 11, 2016

highfive commented Jun 11, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

highfive commented Jun 12, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

cbrewster commented Jun 12, 2016

bors-servo commented Jun 12, 2016

bors-servo commented Jun 12, 2016

asajeffrey commented Jun 7, 2016 •

edited by larsbergstrom