Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for changing an iframe's parentage. #11677

Merged
merged 1 commit into from Jun 9, 2016
Merged

Added a test for changing an iframe's parentage. #11677

merged 1 commit into from Jun 9, 2016

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 8, 2016 •
edited by larsbergstrom

Add a test for what happens when an iframe's parent browsing context changes.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 8, 2016

r? @ConnorGBrewster
@highfive highfive assigned cbrewster and unassigned KiChjang Jun 8, 2016
@KiChjang
Copy link
Member

KiChjang commented Jun 8, 2016

@bors-servo delegate=ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2016

✌️ @ConnorGBrewster can now approve this pull request
@cbrewster
Copy link
Member

cbrewster commented Jun 8, 2016

Looks good!
@bors-servo r+

-S-awaiting-review

Previously, bors-servo wrote…

✌️ @ConnorGBrewster can now approve this pull request

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2016

📌 Commit 23b1dc4 has been approved by ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2016

⌛ Testing commit 23b1dc4 with merge 588a623...
bors-servo added a commit that referenced this pull request Jun 8, 2016
@bors-servo
Auto merge of #11677 - asajeffrey:iframe-change-parentage-test, r=Con…
588a623 
…norGBrewster

Added a test for changing an iframe's parentage.

<!-- Please describe your changes on the following line: -->
Add a test for what happens when an iframe's parent browsing context changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 8, 2016 

  ▶ CRASH [expected OK] /_mozilla/mozilla/iframe/change_parentage.html
  │ 
  │ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.
  │ ERROR:constellation::constellation: Panic: called `Option::unwrap()` on a `None` value
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x00007ff0a682f47d - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x00007ff0a682f405 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x00007ff0a58865a9 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h89adae1a802be550
  │ frame #3  - 0x00007ff0a6820cf8 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::he2b22674ad1748f3
  │ frame #4  - 0x00007ff0a6aeb78c - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x00007ff0a6b05b01 - std::panicking::begin_panic::he426e15a3766089a
  │ frame #6  - 0x00007ff0a6aecffa - std::panicking::begin_panic_fmt::hdddb415186c241e7
  │ frame #7  - 0x00007ff0a6b05a9e - rust_begin_unwind
  │ frame #8  - 0x00007ff0a6b3c09f - core::panicking::panic_fmt::hf4e16cb7f0d41a25
  │ frame #9  - 0x00007ff0a6b3c378 - core::panicking::panic::h907815f47e914305
  │ frame #10 - 0x00007ff0a56abe01 - script::dom::event::Event::new_uninitialized::h05ae188a870e92b9
  │ frame #11 - 0x00007ff0a56b3cbb - script::dom::event::Event::new::h7a12c706eaf845bc
  │ frame #12 - 0x00007ff0a56fabbc - script::dom::eventtarget::EventTarget::fire_event::h0d5b30039f5820d2
  │ frame #13 - 0x00007ff0a58f915a - script::task_source::dom_manipulation::DOMManipulationTask::handle_task::h0ea31f97e475cb7a
  │ frame #14 - 0x00007ff0a5890aa5 - script::script_thread::ScriptThread::handle_msg_from_script::h47e979ae1e7fb676
  │ frame #15 - 0x00007ff0a58dd52f - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::hb50cf7fd97943b65
  │ frame #16 - 0x00007ff0a58c58c9 - script::script_thread::ScriptThread::handle_msgs::h1e1abab71191c950
  │ frame #17 - 0x00007ff0a5884c27 - std::panicking::try::call::h78dcd5319adf08fa
  │ frame #18 - 0x00007ff0a6b0fcfb - __rust_try
  │ frame #19 - 0x00007ff0a6b0fc9e - __rust_maybe_catch_panic
  │ frame #20 - 0x00007ff0a5885f0d - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hce043844655ea6a9
  │ frame #21 - 0x00007ff0a6b03cc4 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #22 - 0x00007ff0a294e181 - start_thread
  │ frame #23 - 0x00007ff0a246547c - __clone
  │ frame #24 - 0x0000000000000000 - &lt;unknown&gt;
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 8, 2016

IRC chat: http://logs.glob.uno/?c=mozilla%23servo&s=8+Jun+2016&e=8+Jun+2016#c451613

TL;DR: intermittents, gah, and @jgraham asked for the tests to be moved under web-patform-tests.
@asajeffrey asajeffrey force-pushed the asajeffrey:iframe-change-parentage-test branch from 23b1dc4 to 0d6c312 Jun 9, 2016
@highfive
Copy link

highfive commented Jun 9, 2016

New code was committed to pull request.
@asajeffrey asajeffrey force-pushed the asajeffrey:iframe-change-parentage-test branch from 0d6c312 to b20af75 Jun 9, 2016
@highfive
Copy link

highfive commented Jun 9, 2016

New code was committed to pull request.
@asajeffrey asajeffrey force-pushed the asajeffrey:iframe-change-parentage-test branch from b20af75 to e21f2d1 Jun 9, 2016
@highfive
Copy link

highfive commented Jun 9, 2016

New code was committed to pull request.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 9, 2016

Moved tests to web-platform-tests, rebased and squashed.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 9, 2016

@bors-servo r=@ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

📌 Commit e21f2d1 has been approved by @ConnorGBrewster
@asajeffrey asajeffrey mentioned this pull request Jun 9, 2016
Merged
4 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

⌛ Testing commit e21f2d1 with merge 453c1eb...
bors-servo added a commit that referenced this pull request Jun 9, 2016
@bors-servo
Auto merge of #11677 - asajeffrey:iframe-change-parentage-test, r=@Co…
453c1eb 
…nnorGBrewster

Added a test for changing an iframe's parentage.

<!-- Please describe your changes on the following line: -->
Add a test for what happens when an iframe's parent browsing context changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Jun 9, 2016 

Running the WPT lint...
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 13
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 14
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 15
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 16
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 17
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 18
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 19
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_parentage.html line 20
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_child.html line 8
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_child.html line 9
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_child.html line 10
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_child.html line 11
INDENT TABS: html/semantics/embedded-content/the-iframe-element/change_child.html line 12
There were 13 errors (INDENT TABS: 13)
@asajeffrey
Added a test for changing an iframe's parentage.
Loading status checks…
999e057
@asajeffrey asajeffrey force-pushed the asajeffrey:iframe-change-parentage-test branch from e21f2d1 to 999e057 Jun 9, 2016
@highfive
Copy link

highfive commented Jun 9, 2016

New code was committed to pull request.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 9, 2016

Grr. Fixed tabs. @bors-servo r=ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

📌 Commit 999e057 has been approved by ConnorGBrewster
@asajeffrey asajeffrey removed the S-fails-tidy label Jun 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

⌛ Testing commit 999e057 with merge 3acb954...
bors-servo added a commit that referenced this pull request Jun 9, 2016
@bors-servo
Auto merge of #11677 - asajeffrey:iframe-change-parentage-test, r=Con…
Loading status checks…
3acb954 
…norGBrewster

Added a test for changing an iframe's parentage.

<!-- Please describe your changes on the following line: -->
Add a test for what happens when an iframe's parent browsing context changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 999e057 into servo:master Jun 9, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck mentioned this pull request Jun 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
A-content/dom A-testing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @KiChjang @bors-servo @cbrewster @highfive @jdm
You can’t perform that action at this time.