Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport keyword values for 'cursor' in geckolib #11688
Conversation
|
Looks good. I suppose we don't want to make a normal Servo build depend on If we see this pattern repeating a lot I guess we can use a helper trait like @bors-servo: r+ -S-awaiting-review +S-awaiting-merge
|
|
|
Support keyword values for 'cursor' in geckolib This has a big hard-coded `match` instead of a generated one because Servo's Cursor enum is not generated by Mako code; instead it's in `style_traits` where it can be shared with Servo's gfx and windowing code. We *could* move this mapping into the macro that generates the Cursor enum, but it would either involve the same amount of code duplication, or make style_traits depend on gecko_bindings. I'm not really sure which is best; open to suggestions. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11688) <!-- Reviewable:end -->
|
|
highfive
commented
Jun 9, 2016
|
|
@bors-servo retry |
Support keyword values for 'cursor' in geckolib This has a big hard-coded `match` instead of a generated one because Servo's Cursor enum is not generated by Mako code; instead it's in `style_traits` where it can be shared with Servo's gfx and windowing code. We *could* move this mapping into the macro that generates the Cursor enum, but it would either involve the same amount of code duplication, or make style_traits depend on gecko_bindings. I'm not really sure which is best; open to suggestions. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11688) <!-- Reviewable:end -->
|
|
highfive
commented
Jun 10, 2016
|
|
@bors-servo retry |
Support keyword values for 'cursor' in geckolib This has a big hard-coded `match` instead of a generated one because Servo's Cursor enum is not generated by Mako code; instead it's in `style_traits` where it can be shared with Servo's gfx and windowing code. We *could* move this mapping into the macro that generates the Cursor enum, but it would either involve the same amount of code duplication, or make style_traits depend on gecko_bindings. I'm not really sure which is best; open to suggestions. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11688) <!-- Reviewable:end -->
|
|
highfive
commented
Jun 10, 2016
|
|
@bors-servo retry |
|
|
|
|
mbrubeck commentedJun 9, 2016
•
edited by larsbergstrom
This has a big hard-coded
matchinstead of a generated one because Servo's Cursor enum is not generated by Mako code; instead it's instyle_traitswhere it can be shared with Servo's gfx and windowing code.We could move this mapping into the macro that generates the Cursor enum, but it would either involve the same amount of code duplication, or make style_traits depend on gecko_bindings. I'm not really sure which is best; open to suggestions.
r? @emilio
This change is