Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for whether only fully active documents contribute to the joint session history #11690

Merged
merged 1 commit into from Jun 11, 2016
Merged

Added test for whether only fully active documents contribute to the joint session history #11690

merged 1 commit into from Jun 11, 2016

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 9, 2016 •
edited by larsbergstrom

The spec https://html.spec.whatwg.org/multipage/#joint-session-history says that only fully active documents contribute to the joint session history, but this appears not to be what's implemented.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 9, 2016

cc @jgraham @ConnorGBrewster
@asajeffrey
Added test for whether only fully active documents contribute to the …
Loading status checks…
fad91e3 
…joint session history.
@asajeffrey asajeffrey force-pushed the asajeffrey:navigation-history-spec-tests branch from 3a1c7eb to fad91e3 Jun 9, 2016
@highfive
Copy link

highfive commented Jun 9, 2016

New code was committed to pull request.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 9, 2016

Rebased.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 10, 2016

r? @ConnorGBrewster
@highfive highfive assigned cbrewster and unassigned KiChjang Jun 10, 2016
@KiChjang
Copy link
Member

KiChjang commented Jun 10, 2016

@bors-servo delegate=ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

✌️ @ConnorGBrewster can now approve this pull request
@cbrewster
Copy link
Member

cbrewster commented Jun 10, 2016

Looks good, pretty clever too!
@bors-servo r+
-S-awaiting-review

Previously, bors-servo wrote…

✌️ @ConnorGBrewster can now approve this pull request

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

📌 Commit fad91e3 has been approved by ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

⌛ Testing commit fad91e3 with merge f2f583f...
bors-servo added a commit that referenced this pull request Jun 11, 2016
@bors-servo
Auto merge of #11690 - asajeffrey:navigation-history-spec-tests, r=Co…
f2f583f 
…nnorGBrewster

Added test for whether only fully active documents contribute to the joint session history

<!-- Please describe your changes on the following line: -->
The spec https://html.spec.whatwg.org/multipage/#joint-session-history says that only fully active documents contribute to the joint session history, but this appears not to be what's implemented.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11690)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

💔 Test failed - mac-rel-css
@cbrewster
Copy link
Member

cbrewster commented Jun 11, 2016

@bors-servo retry

  • Infra
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

⌛ Testing commit fad91e3 with merge 7c2cbcc...
bors-servo added a commit that referenced this pull request Jun 11, 2016
@bors-servo
Auto merge of #11690 - asajeffrey:navigation-history-spec-tests, r=Co…
7c2cbcc 
…nnorGBrewster

Added test for whether only fully active documents contribute to the joint session history

<!-- Please describe your changes on the following line: -->
The spec https://html.spec.whatwg.org/multipage/#joint-session-history says that only fully active documents contribute to the joint session history, but this appears not to be what's implemented.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11690)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Jun 11, 2016 

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:
  │ FAIL [expected PASS] WebGL test #5: at (16, 0) expected: 0,0,0,0 was 255,255,255,255
  │   → assert_true: at (16, 0) expected: 0,0,0,0 was 255,255,255,255 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ testCanvasSizeChange@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:37:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/rendering/gl-scissor-canvas-dimensions.html:42:1

  ▶ TIMEOUT [expected OK] /websockets/constructor/017.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/017.html?wss

  ▶ TIMEOUT [expected OK] /websockets/constructor/018.html?wss

  ▶ TIMEOUT [expected OK] /websockets/constructor/018.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/019.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/019.html?wss

  ▶ TIMEOUT [expected OK] /websockets/constructor/020.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/021.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/021.html?wss

  ▶ TIMEOUT [expected OK] /websockets/constructor/022.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/022.html?wss

  ▶ TIMEOUT [expected OK] /websockets/cookies/001.html

  ▶ TIMEOUT [expected OK] /websockets/cookies/001.html?wss

  ▶ TIMEOUT [expected OK] /websockets/cookies/002.html

  ▶ TIMEOUT [expected OK] /websockets/cookies/003.html

  ▶ TIMEOUT [expected OK] /websockets/cookies/002.html?wss

  ▶ TIMEOUT [expected OK] /websockets/cookies/003.html?wss

  ▶ TIMEOUT [expected OK] /websockets/cookies/004.html

  ▶ TIMEOUT [expected OK] /websockets/constructor/020.html?wss
@cbrewster
Copy link
Member

cbrewster commented Jun 11, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

⌛ Testing commit fad91e3 with merge 90a8aba...
bors-servo added a commit that referenced this pull request Jun 11, 2016
@bors-servo
Auto merge of #11690 - asajeffrey:navigation-history-spec-tests, r=Co…
Loading status checks…
90a8aba 
…nnorGBrewster

Added test for whether only fully active documents contribute to the joint session history

<!-- Please describe your changes on the following line: -->
The spec https://html.spec.whatwg.org/multipage/#joint-session-history says that only fully active documents contribute to the joint session history, but this appears not to be what's implemented.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11690)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

💔 Test failed - mac-rel-css
@metajack
Copy link
Contributor

metajack commented Jun 11, 2016

@bors-servo retry

  • infra (git failure)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt, windows are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit fad91e3 into servo:master Jun 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @highfive @KiChjang @bors-servo @cbrewster @metajack
You can’t perform that action at this time.