Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use less repetitive name #11696

Merged
merged 1 commit into from Jun 12, 2016
Merged

use less repetitive name #11696

merged 1 commit into from Jun 12, 2016

Conversation

@mrmiywj
Copy link
Contributor

mrmiywj commented Jun 10, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11689 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because just renaming

This change is Reviewable
@cbrewster
Copy link
Member

cbrewster commented Jun 10, 2016

Thank you for your contribution!

It looks like you may have not tried compiling with these changes. You will need to go and fix any uses of DefaultCursor, PointerCursor, etc.. throughout the codebase.
@KiChjang
Copy link
Member

KiChjang commented Jun 10, 2016

@bors-servo delegate=ConnorGBrewster
r? @ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

✌️ @ConnorGBrewster can now approve this pull request
@highfive highfive assigned cbrewster and unassigned Manishearth Jun 10, 2016
components/style_traits/cursor.rs Outdated
"all-scroll" => AllScrollCursor = 32,
"zoom-in" => ZoomInCursor = 33,
"zoom-out" => ZoomOutCursor = 34,
"none" => No = 0,

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Jun 10, 2016

Member

None instead of No.
@highfive
Copy link

highfive commented Jun 10, 2016

New code was committed to pull request.
@cbrewster
Copy link
Member

cbrewster commented Jun 10, 2016

Looks good. Thank you for this!

@bors-servo r+
-S-awaiting-review

Previously, highfive wrote…

New code was committed to pull request.

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

📌 Commit 994b5e7 has been approved by ConnorGBrewster
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Testing commit 994b5e7 with merge 18b3de6...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - windows
@cbrewster
Copy link
Member

cbrewster commented Jun 10, 2016

@bors-servo retry

  • Git
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Testing commit 994b5e7 with merge 2770058...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11696 - mrmiywj:rename-to-less-repetitive, r=ConnorGBr…
2770058 
…ewster

use less repetitive name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11689  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just renaming

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11696)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - windows
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-css
@cbrewster
Copy link
Member

cbrewster commented Jun 12, 2016

@bors-servo retry

  • Infra (git)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 46cadfd with merge f92d395...
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11696 - mrmiywj:rename-to-less-repetitive, r=ConnorGBr…
f92d395 
…ewster

use less repetitive name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11689  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just renaming

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11696)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 12, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@cbrewster
Copy link
Member

cbrewster commented Jun 12, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 46cadfd with merge b5115fc...
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11696 - mrmiywj:rename-to-less-repetitive, r=ConnorGBr…
Loading status checks…
b5115fc 
…ewster

use less repetitive name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11689  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just renaming

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11696)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Jun 12, 2016 

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/textures/default-texture.html:
  │ FAIL [expected PASS] WebGL test #0: at (0, 0) expected: 0,0,0,255 was 255,255,255,255
  │   → assert_true: at (0, 0) expected: 0,0,0,255 was 255,255,255,255 expected true got false
  │ 
  │ reportTestResultsToHarness/&lt;@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ checkCanvas@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1095:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/textures/default-texture.html:14:1
@cbrewster
Copy link
Member

cbrewster commented Jun 12, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, windows are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 12, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@cbrewster
Copy link
Member

cbrewster commented Jun 12, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, windows are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 46cadfd into servo:master Jun 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Use less repetitive enum names for Cursor
9 participants
@mrmiywj @cbrewster @KiChjang @bors-servo @highfive @larsbergstrom @metajack @jdm @Manishearth
You can’t perform that action at this time.