Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise SubpageId and use only PipelineIds #11698

Merged
merged 3 commits into from Sep 14, 2016

Commits on Sep 13, 2016

  1. Use fn pipeline_id consistently, not fn pipeline

    Consistently use the name 'pipeline_id' to refer to a function that
    returns an (optional) PipelineId.
    
    This was prompted by discovering both fn pipeline and fn pipeline_id
    doing the same job in htmliframeelement.rs.
    
    Note that there is fn pipeline in components/compositing/compositor.rs,
    but that actually returns an Option<&CompositionPipeline>, not any kind
    of PipelineId.
    aneeshusa committed Sep 13, 2016
  2. Consistently use parent_pipeline_id

    Instead of containing_pipeline_id, use parent_pipeline_id because it is
    more clear that it refers to the immediate parent.
    aneeshusa committed Sep 13, 2016
  3. Excise SubpageId and use only PipelineIds

    SubpageId was originally introduced in 2013 to help iframes keep track of
    their associated (children) pipelines. However, since each pipeline
    already has a PipelineId, and those are unique, those are sufficient
    to keep track of children.
    aneeshusa committed Sep 13, 2016
You can’t perform that action at this time.