Remove an invalid assertion in fire_timer. #11700

Ms2ger · 2016-06-10T07:58:36Z

It's not clear to me if this is something we should expect to happen, but it
does indeed happen, so we should disable the assertion while we investigate.

Fixes #9984.

This change is


        Remove an invalid assertion in fire_timer.

It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.

highfive · 2016-06-10T07:58:40Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/timers.rs

highfive · 2016-06-10T07:58:41Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

jdm · 2016-06-10T07:59:35Z

@bors-servo: r+

bors-servo · 2016-06-10T07:59:36Z

📌 Commit f695842 has been approved by jdm

bors-servo · 2016-06-10T08:08:17Z

⌛ Testing commit f695842 with merge 6bf7f22...


        Auto merge of #11700 - Ms2ger:assert, r=jdm

Remove an invalid assertion in fire_timer. It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)

bors-servo · 2016-06-10T08:52:23Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-10T08:52:26Z

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/change_parentage.html
  │ 
  │ ERROR:constellation::constellation: Panic: resize sent to nonexistent pipeline
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x000000010cd4493e - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x000000010cd448c1 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x000000010c281886 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h6bf1f1518fe13d1a
  │ frame #3  - 0x000000010cd2a177 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x000000010cf39084 - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x000000010bc3da84 - std::panicking::begin_panic::h0bf39f6d43ab9349
  │ frame #6  - 0x000000010c2e1330 - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h41a556e2c2c94fe6
  │ frame #7  - 0x000000010c2c3e32 - script::script_thread::ScriptThread::handle_msgs::h6a699373a020da16
  │ frame #8  - 0x000000010c280057 - std::panicking::try::call::hb8565a24f25031fc
  │ frame #9  - 0x000000010cf54b9b - __rust_try
  │ frame #10 - 0x000000010cf54b35 - __rust_maybe_catch_panic
  │ frame #11 - 0x000000010c2812b4 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h78c73797281bb868
  │ frame #12 - 0x000000010cf50618 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #13 - 0x00007fff8e158059 - _pthread_body
  │ frame #14 - 0x00007fff8e157fd6 - _pthread_start
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!

jdm · 2016-06-10T08:55:53Z

@bors-servo: retry

#11613

bors-servo · 2016-06-10T13:03:25Z

⌛ Testing commit f695842 with merge 17f438b...


        Auto merge of #11700 - Ms2ger:assert, r=jdm

Remove an invalid assertion in fire_timer. It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)

bors-servo · 2016-06-10T13:49:52Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-10T13:49:55Z

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/change_parentage.html
  │ 
  │ ERROR:constellation::constellation: Panic: resize sent to nonexistent pipeline
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x000000010d04b17e - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x000000010d04b101 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x000000010c587d36 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h6bf1f1518fe13d1a
  │ frame #3  - 0x000000010d0309b7 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x000000010d23f8c4 - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x000000010bf43f34 - std::panicking::begin_panic::h0bf39f6d43ab9349
  │ frame #6  - 0x000000010c5e77e0 - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h41a556e2c2c94fe6
  │ frame #7  - 0x000000010c5ca2e2 - script::script_thread::ScriptThread::handle_msgs::h6a699373a020da16
  │ frame #8  - 0x000000010c586507 - std::panicking::try::call::hb8565a24f25031fc
  │ frame #9  - 0x000000010d25b3db - __rust_try
  │ frame #10 - 0x000000010d25b375 - __rust_maybe_catch_panic
  │ frame #11 - 0x000000010c587764 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h78c73797281bb868
  │ frame #12 - 0x000000010d256e58 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #13 - 0x00007fff88bee059 - _pthread_body
  │ frame #14 - 0x00007fff88bedfd6 - _pthread_start
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!

jdm · 2016-06-10T13:55:19Z

@bors-servo: retry
#11613

bors-servo · 2016-06-10T17:34:52Z

⌛ Testing commit f695842 with merge a1ae221...

jdm · 2016-06-10T17:53:54Z

@bors-servo: retry

infra

bors-servo · 2016-06-10T17:53:57Z

⌛ Testing commit f695842 with merge b5232bf...


        Auto merge of #11700 - Ms2ger:assert, r=jdm

Remove an invalid assertion in fire_timer. It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)

bors-servo · 2016-06-10T17:54:01Z

💔 Test failed - windows

larsbergstrom · 2016-06-10T20:32:21Z

@bors-servo retry

#11719

larsbergstrom · 2016-06-10T20:32:59Z

@bors-servo retry

#11719

bors-servo · 2016-06-10T21:13:44Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only windows...

bors-servo · 2016-06-10T21:13:45Z

💔 Test failed - windows

metajack · 2016-06-10T21:40:13Z

@bors-servo retry

#11719

bors-servo · 2016-06-10T23:04:49Z

⌛ Testing commit f695842 with merge d797000...


        Auto merge of #11700 - Ms2ger:assert, r=jdm

Remove an invalid assertion in fire_timer. It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)

bors-servo · 2016-06-10T23:39:50Z

💔 Test failed - mac-rel-css

jdm · 2016-06-11T01:08:39Z

@bors-servo: retry

git timed out


        Auto merge of #11700 - Ms2ger:assert, r=jdm

Remove an invalid assertion in fire_timer. It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)

bors-servo · 2016-06-11T23:42:54Z

⌛ Testing commit f695842 with merge 3fa0dca...

bors-servo · 2016-06-12T00:30:26Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

Remove an invalid assertion in fire_timer.

Loading status checks…

f695842

It's not clear to me if this is something we should expect to happen, but it does indeed happen, so we should disable the assertion while we investigate. Fixes #9984.

highfive assigned nox Jun 10, 2016

highfive added the S-awaiting-review label Jun 10, 2016

highfive assigned jdm and unassigned nox Jun 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 10, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 10, 2016

highfive removed the S-tests-failed label Jun 10, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 10, 2016

highfive added the S-tests-failed label Jun 10, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 10, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 11, 2016

bors-servo merged commit f695842 into servo:master Jun 12, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jun 12, 2016

Ms2ger deleted the Ms2ger:assert branch Jun 16, 2016

servo / servo

Remove an invalid assertion in fire_timer. #11700

Remove an invalid assertion in fire_timer. #11700

Ms2ger commented Jun 10, 2016 •

edited by larsbergstrom

highfive commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

larsbergstrom commented Jun 10, 2016

larsbergstrom commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

metajack commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

jdm commented Jun 11, 2016

bors-servo commented Jun 11, 2016

bors-servo commented Jun 12, 2016

servo / servo

Join GitHub today

Remove an invalid assertion in fire_timer. #11700

Remove an invalid assertion in fire_timer. #11700

Conversation

Ms2ger commented Jun 10, 2016 • edited by larsbergstrom

highfive commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

highfive commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

jdm commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

larsbergstrom commented Jun 10, 2016

larsbergstrom commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

metajack commented Jun 10, 2016

bors-servo commented Jun 10, 2016

bors-servo commented Jun 10, 2016

jdm commented Jun 11, 2016

bors-servo commented Jun 11, 2016

bors-servo commented Jun 12, 2016

Ms2ger commented Jun 10, 2016 •

edited by larsbergstrom