Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an invalid assertion in fire_timer. #11700

Merged
merged 1 commit into from Jun 12, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Remove an invalid assertion in fire_timer.

It's not clear to me if this is something we should expect to happen, but it
does indeed happen, so we should disable the assertion while we investigate.

Fixes #9984.
  • Loading branch information
Ms2ger committed Jun 10, 2016
commit f695842df703383040fb4261eaf5174a788be0a8
@@ -176,7 +176,10 @@ impl OneshotTimers {
let base_time = self.base_time();

// Since the event id was the expected one, at least one timer should be due.
assert!(base_time >= self.timers.borrow().last().unwrap().scheduled_for);
if base_time < self.timers.borrow().last().unwrap().scheduled_for {
warn!("Unexpected timing!");
return;
}

// select timers to run to prevent firing timers
// that were installed during fire of another timer
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.