Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load all font faces sources #11702

Merged
merged 1 commit into from Jun 10, 2016
Merged

Don't load all font faces sources #11702

merged 1 commit into from Jun 10, 2016

Conversation

@nox
Copy link
Member

nox commented Jun 10, 2016 •
edited by larsbergstrom

We stop at the first one we manage to load.

This change is Reviewable
@highfive
Copy link

highfive commented Jun 10, 2016

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jun 10, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Trying commit ad63d60 with merge d9262ce...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11702 - nox:fonts, r=<try>
d9262ce 
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - mac-dev-unit
@nox nox force-pushed the nox:fonts branch from ad63d60 to 10d82a0 Jun 10, 2016
@highfive
Copy link

highfive commented Jun 10, 2016

New code was committed to pull request.
@nox nox force-pushed the nox:fonts branch from 10d82a0 to 615f4aa Jun 10, 2016
@highfive
Copy link

highfive commented Jun 10, 2016

New code was committed to pull request.
@nox
Copy link
Member Author

nox commented Jun 10, 2016

r? @metajack
@highfive highfive assigned metajack and unassigned glennw Jun 10, 2016
@nox
Copy link
Member Author

nox commented Jun 10, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Trying commit 615f4aa with merge 2059788...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11702 - nox:fonts, r=<try>
2059788 
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - linux-dev
@nox nox force-pushed the nox:fonts branch from 615f4aa to a3a1260 Jun 10, 2016
@highfive
Copy link

highfive commented Jun 10, 2016

New code was committed to pull request.
@nox
Copy link
Member Author

nox commented Jun 10, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Trying commit a3a1260 with merge 37410f6...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11702 - nox:fonts, r=<try>
37410f6 
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - linux-dev
@metajack
Copy link
Contributor

metajack commented Jun 10, 2016

r=me after answering the .rev() question

Previously, bors-servo wrote…

💔 Test failed - linux-dev

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

components/style/font_face.rs, line 70 [r3] (raw file):

    /// least "truetype" or "opentype".
    pub fn effective_sources(&self) -> EffectiveSources {
        EffectiveSources(self.sources.iter().rev().filter(|source| {

Why do we reverse the list here?x

Comments from Reviewable
@nox
Don't load all font faces sources
Loading status checks…
b97c7a8 
We stop at the first one we manage to load.
@nox nox force-pushed the nox:fonts branch from a3a1260 to b97c7a8 Jun 10, 2016
@highfive
Copy link

highfive commented Jun 10, 2016

New code was committed to pull request.
@nox
Copy link
Member Author

nox commented Jun 10, 2016

Fixed the unit tests and Jack ACK'd my answer on IRC.

@bors-servo r=metajack

Previously, highfive wrote…

New code was committed to pull request.

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

📌 Commit b97c7a8 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Testing commit b97c7a8 with merge 45fdb7f...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11702 - nox:fonts, r=metajack
45fdb7f 
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - windows
@nox
Copy link
Member Author

nox commented Jun 10, 2016

@bors-servo retry #JustInfraThings
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⌛ Testing commit b97c7a8 with merge ce88b8e...
bors-servo added a commit that referenced this pull request Jun 10, 2016
@bors-servo
Auto merge of #11702 - nox:fonts, r=metajack
Loading status checks…
ce88b8e 
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - windows
@metajack
Copy link
Contributor

metajack commented Jun 10, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⚡ Previous build results for android, arm64, linux-dev, mac-dev-unit are reusable. Rebuilding only arm32, linux-rel, mac-rel-css, mac-rel-wpt, windows...
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 10, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt, windows are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit b97c7a8 into servo:master Jun 10, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 10, 2016
Closed
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @bors-servo @metajack @larsbergstrom @glennw
You can’t perform that action at this time.