Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test of DataSlice #11711

Closed
wants to merge 1 commit into from
Closed

Improve unit test of DataSlice #11711

wants to merge 1 commit into from

Conversation

@izgzhen
Copy link
Contributor

izgzhen commented Jun 10, 2016 •
edited

Add three more cases. relevant spec https://w3c.github.io/FileAPI/#slice-method-algo

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

related to #11131

  • There are tests for these changes OR

This change is Reviewable
@Manishearth
Copy link
Member

Manishearth commented Jun 11, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2016

📌 Commit 416bb89 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned mbrubeck Jun 11, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 416bb89 with merge e2adaa2...
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11711 - izgzhen:improve-blob-unit-test, r=Manishearth
e2adaa2 
Improve unit test of DataSlice

Add three more cases. relevant spec https://w3c.github.io/FileAPI/#slice-method-algo

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

related to #11131

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11711)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-css
@izgzhen
Copy link
Contributor Author

izgzhen commented Jun 12, 2016 •
edited

@bors-servo retry

Exception git
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 416bb89 with merge 6363bba...
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11711 - izgzhen:improve-blob-unit-test, r=Manishearth
6363bba 
Improve unit test of DataSlice

Add three more cases. relevant spec https://w3c.github.io/FileAPI/#slice-method-algo

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

related to #11131

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11711)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-css
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11711 - izgzhen:improve-blob-unit-test, r=Manishearth
6ef58ae 
Improve unit test of DataSlice

Add three more cases. relevant spec https://w3c.github.io/FileAPI/#slice-method-algo

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

related to #11131

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11711)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 416bb89 with merge 6ef58ae...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 12, 2016 

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/change_parentage.html
  │ 
  │ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.
  │ ERROR:constellation::constellation: Panic: ScriptThread: received an event message for a layout channel that is not associated with this script thread.This is a bug.
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x00007f43c0e2f72d - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x00007f43c0e2f6b5 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x00007f43bfe59b99 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h89adae1a802be550
  │ frame #3  - 0x00007f43c0e20f68 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::he2b22674ad1748f3
  │ frame #4  - 0x00007f43c10eeb4c - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x00007f43c1108f51 - std::panicking::begin_panic::he426e15a3766089a
  │ frame #6  - 0x00007f43c10f03ba - std::panicking::begin_panic_fmt::hdddb415186c241e7
  │ frame #7  - 0x00007f43c1108eee - rust_begin_unwind
  │ frame #8  - 0x00007f43c113f4ef - core::panicking::panic_fmt::hf4e16cb7f0d41a25
  │ frame #9  - 0x00007f43c1146ba4 - core::option::expect_failed::hdb92832549f56a85
  │ frame #10 - 0x00007f43bfe66bd1 - script::script_thread::ScriptThread::handle_msg_from_script::h47e979ae1e7fb676
  │ frame #11 - 0x00007f43bfeb29df - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::hb50cf7fd97943b65
  │ frame #12 - 0x00007f43bfe99f87 - script::script_thread::ScriptThread::handle_msgs::h1e1abab71191c950
  │ frame #13 - 0x00007f43bfe58217 - std::panicking::try::call::h78dcd5319adf08fa
  │ frame #14 - 0x00007f43c111314b - __rust_try
  │ frame #15 - 0x00007f43c11130ee - __rust_maybe_catch_panic
  │ frame #16 - 0x00007f43bfe594fd - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hce043844655ea6a9
  │ frame #17 - 0x00007f43c1107114 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #18 - 0x00007f43bcf4a183 - start_thread
  │ frame #19 - 0x00007f43bca6137c - clone
  │ frame #20 - 0x0000000000000000 - &lt;unknown&gt;
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!
@izgzhen
Improve unit test of DataSlice
Loading status checks…
f34ea06
@izgzhen izgzhen force-pushed the izgzhen:improve-blob-unit-test branch from 416bb89 to f34ea06 Jun 12, 2016
@highfive
Copy link

highfive commented Jun 12, 2016

New code was committed to pull request.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 12, 2016

I'm a little unhappy about writing unit tests for this. Can't we write wpt tests?
@izgzhen
Copy link
Contributor Author

izgzhen commented Jun 12, 2016

@Ms2ger okay, I should have thought that. Sounds good to me
@izgzhen izgzhen closed this Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@izgzhen @Manishearth @bors-servo @highfive @Ms2ger @mbrubeck
You can’t perform that action at this time.