Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to update-core #11718

Merged
merged 1 commit into from Jun 12, 2016
Merged

Removed reference to update-core #11718

merged 1 commit into from Jun 12, 2016

Conversation

@perlun
Copy link
Contributor

perlun commented Jun 10, 2016

It's pacman -Su nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)


This change is Reviewable

Per Lundberg
It's `pacman -Su` nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)
@perlun
Copy link
Contributor Author

perlun commented Jun 10, 2016

@highfive highfive assigned metajack and unassigned asajeffrey Jun 10, 2016
@metajack
Copy link
Contributor

metajack commented Jun 10, 2016

@bors-servo r+

Previously, perlun (Per Lundberg) wrote…

r? @metajack


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

📌 Commit b888f89 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

Testing commit b888f89 with merge 2e9e6a5...

bors-servo added a commit that referenced this pull request Jun 10, 2016
Removed reference to update-core

It's `pacman -Su` nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

💔 Test failed - windows

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 10, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

Testing commit b888f89 with merge 2cd7194...

bors-servo added a commit that referenced this pull request Jun 12, 2016
Removed reference to update-core

It's `pacman -Su` nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Jun 12, 2016

@bors-servo: retry

  • infra (git timeout)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

Testing commit b888f89 with merge ae056ce...

bors-servo added a commit that referenced this pull request Jun 12, 2016
Removed reference to update-core

It's `pacman -Su` nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Jun 12, 2016

@bors-servo: retry

  • infra (git timeout)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

Testing commit b888f89 with merge 7f4fe45...

bors-servo added a commit that referenced this pull request Jun 12, 2016
Removed reference to update-core

It's `pacman -Su` nowadays, per Alexpux/MSYS2-pacman#26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11718)
<!-- Reviewable:end -->
@perlun
Copy link
Contributor Author

perlun commented Jun 12, 2016

@jdm, thanks for your perseverance. :)

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

@bors-servo bors-servo merged commit b888f89 into servo:master Jun 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@perlun perlun deleted the perlun:patch-3 branch Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.