Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type of HTMLIFrameElement.sandbox #11720

Merged
merged 2 commits into from Jun 12, 2016
Merged

Fix the type of HTMLIFrameElement.sandbox #11720

merged 2 commits into from Jun 12, 2016

Conversation

@canova
Copy link
Member

canova commented Jun 10, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11598 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
canova added 2 commits Jun 10, 2016
@canova
Change sandbox to sandbox_allowance in HTMLIFrameElement
41230fe
@canova
Add Sandbox field to HTMLIFrameElement
Loading status checks…
47984a5
@highfive
Copy link

highfive commented Jun 10, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/webidls/HTMLIFrameElement.webidl
@nox nox removed the S-awaiting-review label Jun 10, 2016
@nox
Copy link
Member

nox commented Jun 10, 2016

-S-awaiting-review

@bors-servo r+

Thanks for your contribution!

Previously, highfive wrote…

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/webidls/HTMLIFrameElement.webidl

Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 10, 2016

📌 Commit 47984a5 has been approved by nox
@highfive highfive assigned nox and unassigned glennw Jun 10, 2016
bors-servo added a commit that referenced this pull request Jun 12, 2016
@bors-servo
Auto merge of #11720 - canaltinova:sandbox, r=nox
Loading status checks…
278c1a7 
Fix the type of HTMLIFrameElement.sandbox

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11598 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11720)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⌛ Testing commit 47984a5 with merge 278c1a7...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jun 12, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 12, 2016 

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/change_parentage.html
  │ 
  │ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.
  │ ERROR:constellation::constellation: Panic: ScriptThread: received an event message for a layout channel that is not associated with this script thread.This is a bug.
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x00007f2eb10400ad - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x00007f2eb1040035 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x00007f2eb006a519 - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::h89adae1a802be550
  │ frame #3  - 0x00007f2eb10318e8 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::he2b22674ad1748f3
  │ frame #4  - 0x00007f2eb12ff4cc - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x00007f2eb13198d1 - std::panicking::begin_panic::he426e15a3766089a
  │ frame #6  - 0x00007f2eb1300d3a - std::panicking::begin_panic_fmt::hdddb415186c241e7
  │ frame #7  - 0x00007f2eb131986e - rust_begin_unwind
  │ frame #8  - 0x00007f2eb134fe6f - core::panicking::panic_fmt::hf4e16cb7f0d41a25
  │ frame #9  - 0x00007f2eb1357524 - core::option::expect_failed::hdb92832549f56a85
  │ frame #10 - 0x00007f2eb0077551 - script::script_thread::ScriptThread::handle_msg_from_script::h47e979ae1e7fb676
  │ frame #11 - 0x00007f2eb00c335f - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::hb50cf7fd97943b65
  │ frame #12 - 0x00007f2eb00aa907 - script::script_thread::ScriptThread::handle_msgs::h1e1abab71191c950
  │ frame #13 - 0x00007f2eb0068b97 - std::panicking::try::call::h78dcd5319adf08fa
  │ frame #14 - 0x00007f2eb1323acb - __rust_try
  │ frame #15 - 0x00007f2eb1323a6e - __rust_maybe_catch_panic
  │ frame #16 - 0x00007f2eb0069e7d - _&lt;F as alloc..boxed..FnBox&lt;A&gt;&gt;::call_box::hce043844655ea6a9
  │ frame #17 - 0x00007f2eb1317a94 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #18 - 0x00007f2ead15d183 - start_thread
  │ frame #19 - 0x00007f2eacc7437c - clone
  │ frame #20 - 0x0000000000000000 - &lt;unknown&gt;
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!
@jdm
Copy link
Member

jdm commented Jun 12, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 47984a5 into servo:master Jun 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 12, 2016
Merged
4 of 5 tasks complete
@canova canova deleted the canova:sandbox branch Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fix the type of HTMLIFrameElement.sandbox
6 participants
@canova @highfive @nox @bors-servo @jdm @glennw
You can’t perform that action at this time.