add reload keyboard shortcut

[mrmiywj]

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #11686 (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because this cannot be automated tested.

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @asajeffrey: components/constellation/constellation.rs
• @KiChjang: components/script/script_thread.rs, components/script_traits/lib.rs, components/script_traits/lib.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[KiChjang]

This fails tidy and is missing the preferences that @paulrouget specified in the issue.

[cbrewster]

From travis:

Checking files for tidiness...
./components/script/script_thread.rs:2054: use statement is not in alphabetical order
    expected: dom::bindings::codegen::Bindings::WindowBinding::WindowMethods
    found: dom::bindings::codegen::Bindings::LocationBinding::LocationMethods

[highfive]

New code was committed to pull request.

[mrmiywj]

@KiChjang Sorry for that I missed this tidy

[mrmiywj]

The preference has been renamed and guarded the key shortcut.

[cbrewster]

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

---

components/script/script_thread.rs, line 2053 [r1] (raw file):

    fn handle_reload(&self, pipeline_id: PipelineId) {
        use dom::bindings::codegen::Bindings::WindowBinding::WindowMethods;

nit: could we move these use statements to the top of the file?

---

Comments from Reviewable

[mrmiywj]

@ConnorGBrewster I used to write use statements on the top of file, but I'm not sure whether it will dirty the namespace. So I used it in this clause.

[highfive]

New code was committed to pull request.

[mrmiywj]

@jdm -reply

[jdm]

My apologies for the delay - I was at an event all last week. I'll review this today.

[paulrouget]

s/enable/enabled

[jdm]

This looks fine; just a few small changes required to merge. Thanks for doing this work!
-S-awaiting-review +S-needs-code-changes

---

Reviewed 6 of 6 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

components/constellation/constellation.rs, line 1399 [r1] (raw file):

        match root_pipeline_id {
            Some(pipeline_id) => {

This can be an if let instead of a match.

---

components/script/script_thread.rs, line 2055 [r1] (raw file):

        use dom::bindings::codegen::Bindings::WindowBinding::WindowMethods;
        use dom::bindings::codegen::Bindings::LocationBinding::LocationMethods;
        let context = self.browsing_context.get().unwrap().find(pipeline_id).expect("There is no such context");

Let's use self.find_child_context(pipeline_id) instead, and just return if it can't be found.

---

components/script_traits/lib.rs, line 192 [r1] (raw file):

    /// Report an error from a CSS parser for the given pipeline
    ReportCSSError(PipelineId, String, usize, usize, String),
    /// Reload the current page.

Reload the given page

---

Comments from Reviewable

[mrmiywj]

@jdm -reply

[paulrouget]

You also need to change quit-on-escape to builtin-key-shortcuts in:

• python/servo/package_commands.py
• python/servo/post_build_commands.py

[jdm]

@mrmiywj Just so you know, when you push new changes to a branch there's a github notification and emails that are sent out. You don't need to explicitly do the "-reply" thing each time.

[jdm]

@bors-servo: r+
Thanks @mrmiywj!

---

Reviewed 4 of 4 files at r4, 8 of 8 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[bors-servo]

📌 Commit 909f0da has been approved by jdm

[bors-servo]

⌛ Testing commit 909f0da with merge eeed5b6...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows