Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ref/RefMut::map rather than transmute for ServoLayoutNode. #11736

Merged
merged 1 commit into from Jun 13, 2016
Merged

Use Ref/RefMut::map rather than transmute for ServoLayoutNode. #11736

merged 1 commit into from Jun 13, 2016
+2 −2

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 13, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Use Ref/RefMut::map rather than transmute for ServoLayoutNode.
Loading status checks…
172aa22
@highfive
Copy link

highfive commented Jun 13, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 13, 2016

@bors-servo: r+
Nice improvement.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2016

📌 Commit 172aa22 has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Jun 13, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2016

⌛ Testing commit 172aa22 with merge e32b2c9...
bors-servo added a commit that referenced this pull request Jun 13, 2016
@bors-servo
Auto merge of #11736 - Ms2ger:detransmute, r=jdm
Loading status checks…
e32b2c9 
Use Ref/RefMut::map rather than transmute for ServoLayoutNode.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11736)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 13, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@jdm
Copy link
Member

jdm commented Jun 13, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 172aa22 into servo:master Jun 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:detransmute branch Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @KiChjang
You can’t perform that action at this time.