Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplementing Box Sizing for Stylo #11743
Merged
Conversation
|
r? @emilio |
|
@emilio Can we add test to it or it's hard to test? |
ports/geckolib/properties.mako.rs
Outdated
| @@ -380,7 +380,6 @@ impl Debug for ${style_struct.gecko_struct_name} { | |||
| # These have unusual representations in gecko. | |||
| force_stub += ["list-style-type", "text-overflow"] | |||
| # Enum class instead of NS_STYLE_... | |||
This comment has been minimized.
This comment has been minimized.
ports/geckolib/properties.mako.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn copy_box_sizing_from(&mut self, other: &Self) { |
This comment has been minimized.
This comment has been minimized.
emilio
Jun 14, 2016
Member
This could probably use the impl_simple_copy helper, though it's not a huge blocker.
r=me with @Ms2ger's comment addressed and (preferably, but optionally) this :)
ports/geckolib/properties.mako.rs
Outdated
| use gecko_bindings::structs::StyleBoxSizing; | ||
| self.gecko.mBoxSizing = match v { | ||
| T::content_box => StyleBoxSizing::Content, | ||
| T::border_box => StyleBoxSizing::Border |
This comment has been minimized.
This comment has been minimized.
emilio
Jun 14, 2016
Member
Also, please add a note here about padding-box, something like:
// TODO: guess what to do with box-sizing: padding-box
Thanks for your contribution! :)
ports/geckolib/properties.mako.rs
Outdated
| T::border_box => StyleBoxSizing::Border | ||
| } | ||
| } | ||
| <%call expr="impl_simple_copy('box_sizing', 'mBoxSizing')"></%call> |
This comment has been minimized.
This comment has been minimized.
emilio
Jun 17, 2016
Member
Can't this just be ${impl_simple_copy('box_sizing', 'mBoxSizing')}.
If not, it's fine to merge :)
|
Cool, thanks for doing this @shinglyu! @bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 23, 2016
Implementing Box Sizing for Stylo <!-- Please describe your changes on the following line: --> Implementing box-sizing for Stylo --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11743) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jun 23, 2016
Implementing Box Sizing for Stylo <!-- Please describe your changes on the following line: --> Implementing box-sizing for Stylo --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11743) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
shinglyu commentedJun 14, 2016
•
edited by larsbergstrom
Implementing box-sizing for Stylo
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is